Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Unix NegotiateStream: Addressing PR feedback #7317

Merged
stephentoub merged 1 commit into from
Apr 6, 2016
Merged

Unix NegotiateStream: Addressing PR feedback #7317

stephentoub merged 1 commit into from
Apr 6, 2016
+77 −85

Conversation

@kapilash
Copy link
Contributor

@kapilash kapilash commented Mar 29, 2016

#7031 listed out the places in NegotiateStream that needed fix.

This PR addresses those of the comments where the scope is limited to NegotiateStream functionality.

Specifically,

  • the tests are cleaned up to remove boilerplate code.
  • SecurityStatusAdapterPal is changed to include a static constructor in the Debug mode.
  • Constants in pal_gssapi.cpp are defined at a single location.
  • CMakeLists.txt is modified to give proper, OS-specific error message

@kapilash
NegotiateStream: Code Cleanup
aec145e 
NegotiateStreamTests are cleaned up to remove boiler-plate code.
Minor Code cleanup to accomodate PR feedback

OS specific error message for native dependencies
@dotnet-bot dotnet-bot changed the title Unix NegotiateStream: Addressing PR feedback Unix NegotiateStream: Addressing PR feedback Mar 29, 2016
@kapilash
Copy link
Contributor Author

kapilash commented Mar 29, 2016

The PR covers the following points from #7031

3. Fix up boiler plate code in KerberosTest.cs
6. Debug only constructor with an assert for size
8. Task array initialization without sizes
11. Unncessary blank lines
12. Possible fix CMake error for message
14 Move the gss_mech_spnego_OID_desc to beside other constant

cc: @stephentoub

@stephentoub
Copy link
Member

stephentoub commented Mar 29, 2016

LGTM

@kapilash
Copy link
Contributor Author

kapilash commented Mar 29, 2016

@dotnet-bot test outerloop rhel7.2 debug

@kapilash
Copy link
Contributor Author

kapilash commented Mar 30, 2016

@dotnet-bot test this please

@stephentoub stephentoub reopened this Mar 30, 2016
@stephentoub stephentoub reopened this Mar 31, 2016
@kapilash
Copy link
Contributor Author

kapilash commented Mar 31, 2016

Both outerloop tests failed with Build timed out (after 120 minutes). Marking the build as aborted.

@kapilash
Copy link
Contributor Author

kapilash commented Apr 1, 2016

@dotnet-bot test outerloop rhel7.2 debug

@kapilash
Copy link
Contributor Author

kapilash commented Apr 1, 2016

outerloop RHEL failure is:

’: No space left on device: No space left on device
00:04:32 : No space left on device

@stephentoub
Copy link
Member

stephentoub commented Apr 3, 2016

Test OuterLoop Ubuntu14.04 Debug please

@stephentoub
Copy link
Member

stephentoub commented Apr 6, 2016

I'm going to go ahead and merge this. It passed outerloop on RHEL, and outerloop on Ubuntu is currently broken due to #7455.

@stephentoub stephentoub merged commit a9c4fbd into dotnet:master Apr 6, 2016
@kapilash kapilash deleted the CodeCleanUp branch April 11, 2016 06:05
@karelz karelz modified the milestone: 1.0.0-rtm Dec 3, 2016
@karelz karelz added the os-linux Linux OS (any supported distro) label Mar 8, 2017
@kapilash kapilash mentioned this pull request Jan 31, 2020
Closed
picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
@stephentoub
Merge pull request dotnet/corefx#7317 from kapilash/CodeCleanUp
f348637 
Unix NegotiateStream: Addressing PR feedback

Commit migrated from dotnet/corefx@a9c4fbd
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

area-System.Net os-linux Linux OS (any supported distro)

Projects

None yet

Milestone

1.0.0-rtm

Development

Successfully merging this pull request may close these issues.

6 participants

@kapilash @stephentoub @karelz @davidsh @dotnet-bot @dnfclas