Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Conversation

@jamesqo
Copy link
Contributor

@jamesqo jamesqo commented Apr 16, 2016

Pass in the current WinHttpResponseStream as a state parameter to the continuation, so we avoid a closure. Also unindented the code.

cc @davidsh @stephentoub


edit: Just updated it to pass in the method parameters as state, as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hold on, don't merge this just yet; it looks like a closure for token is also being implicitly allocated here. Will patch in a moment.

@jamesqo
Copy link
Contributor Author

jamesqo commented Apr 17, 2016

test innerloop osx debug build and test

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe in the future TcsQueryDataAvailable could be changed to a subclass of TaskCompletionSource holding the relevant data to avoid the tuple allocation (similar to what was done in #7788), but for now I'm leaving this PR as-is.

@davidsh
Copy link
Contributor

davidsh commented Apr 22, 2016

@jamesqo I am thinking about doing some potential refactoring of this class to address some cancellation issues when reading response streams. I want to hold this PR for now until that issue is worked out. Thanks.

@jamesqo
Copy link
Contributor Author

jamesqo commented Apr 22, 2016

@davidsh Sure, no problem.

@Petermarcu
Copy link
Member

@davidsh , are you still working on the refactorings that you mentioned? What are the next steps on this PR?

@davidsh
Copy link
Contributor

davidsh commented Jul 15, 2016

@jamesqo Thank you for your work on this PR. We are still involved in reworking parts of WinHttpResponseStream especially dealing with existing memory leaks etc. So, it would be best to close out this PR at this time.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants