Moving SafeDeleteContext and SafeFreeCredentials to common location

[kapilash]

SafeFreeCredentials and SafeDeleteContext are used across two native libraries - libssl and System.Net.Security.Native.
Moving these two classes a common location.

[kapilash]

This is in response to a PR comment received

[kapilash]

cc: @stephentoub

[stephentoub]

cc: @bartonjs

[bartonjs]

Everything left in this file (for example, this class) should be also moved to new files so we can delete the whole libssl directory

[kapilash]

Split the file into different classes. I moved the classes which are under System.Net.Security namespace to $(COMMONPATH)\System\Net\Security\Unix and those in default namespace (Interop.*) to $(COMMONPATH)\Interop\Unix\System.Security.Cryptography.Native
Please let me know if you have any other location in mind

[stephentoub]

Test Innerloop CentOS7.1 Debug Build and Test please

[kapilash]

@dotnet-bot test outerloop rhel7.2 release

[kapilash]

Outerloop test failure is due to

    08:38:16 Unhandled Exception: System.InvalidOperationException: This operation is only allowed using a successfully authenticated context.
    08:38:16    at System.Net.Security.SslState.CheckThrow(Boolean authSucessCheck)
    08:38:16    at System.Net.Security.SslState.get_SecureStream()
    08:38:16    at System.Net.Security.SslStream.Read(Byte[] buffer, Int32 offset, Int32 count)
    08:38:16    at System.IO.Stream.<>c.<BeginReadInternal>b__38_0(Object <arg>)
    08:38:16    at System.Threading.Tasks.Task`1.InnerInvoke()
    08:38:16    at System.Threading.Tasks.Task.Execute()
    08:38:16 --- End of stack trace from previous location where exception was thrown ---
    08:38:16    at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
    08:38:16    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
    08:38:16    at System.IO.Stream.EndRead(IAsyncResult asyncResult)
    08:38:16    at System.Net.Security.Tests.DummyTcpServer.OnReceive(IAsyncResult result)
    08:38:16    at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)
    08:38:16    at System.IO.Stream.ReadWriteTask.System.Threading.Tasks.ITaskCompletionAction.Invoke(Task completingTask)
    08:38:16    at System.Threading.Tasks.Task.FinishContinuations()
    08:38:16    at System.Threading.Tasks.Task.Finish(Boolean bUserDelegateExecuted)
    08:38:16    at System.Threading.Tasks.Task.ExecuteWithThreadLocal(Task& currentTaskSlot)
    08:38:16    at System.Threading.Tasks.Task.ExecuteEntry(Boolean bPreventDoubleExecution)
    08:38:16    at System.Threading.ThreadPoolWorkQueue.Dispatch()
    08:38:30 ./RunTests.sh: line 198: 33435 Aborted                 (core dumped) ./corerun xunit.console.netcore.exe System.Net.Security.Tests.dll -xml testResults.xml -notrait Benchmark=true -notrait category=IgnoreForCI -notrait category=failing -notrait category=nonlinuxtests

I think this is same as #8472 (which should get fixed with new packages)

[bartonjs]

These seem like they could be deleted...

[kapilash]

thank you. I missed these. Removed them now

[kapilash]

Both the inner loop failures are in System.Runtime.Loader.Tests. Not yet sure why they fail only on CentOS

                        System.Runtime.Loader.Tests.AssemblyLoadContextTest.LoadFromAssemblyName_ValidTrustedPlatformAssembly [FAIL]
      06:51:24       Assert.Throws() Failure
      06:51:24       Expected: typeof(System.IO.FileLoadException)
      06:51:24       Actual:   (No exception was thrown)
      06:51:24       Stack Trace:
      06:51:24             at  System.Runtime.Loader.Tests.AssemblyLoadContextTest.LoadFromAssemblyName_ValidTrustedPlatformAssembly()

[kapilash]

@dotnet-bot test outerloop rhel7.2 release

[kapilash]

@dotnet-bot test Innerloop CentOS7.1 debug

[kapilash]

@dotnet-bot test this please

[bartonjs]

Looks a lot better. Thanks, Hemanth.