This repository was archived by the owner on Nov 1, 2020. It is now read-only.
Fix timer firing bug introduced in commit e652d4d (#6905 / #6898) #7069
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkotas
reviewed
Feb 22, 2019
jkotas
reviewed
Feb 22, 2019
filipnavara
force-pushed
the
timerquickfix
branch
from
c1c4433 to
e7d19fe
Compare
kouvel
approved these changes
Feb 22, 2019
Member
|
@filipnavara Thank you! |
kouvel
added a commit
to dotnet/corefx
that referenced
this pull request
Apr 5, 2019
Add a timer test - Separated from #35502 - Added test from dotnet/corert#7069 to CoreFX
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is minimal fix for the problem described in #7066. I took the liberty to also include the accompanying test from that PR. I fully anticipate that this fix will eventually get superseded by the fix from #7066, but I would like to fix the regression as fast as possible for the master builds without waiting for unrelated changes to diagnostic counters.
/cc @kouvel @jkotas