This repository was archived by the owner on Nov 1, 2020. It is now read-only.
Wasm: Change boolean logic for gc.cpp find_object #8245
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Would you mind submitting the gc.cpp change to dotnet/runtime ? |
Contributor
Author
|
Closing as replaced by dotnet/runtime#39905 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the suggestion in #8205. I'm submitting the PR as with this change and #8171 its possible to run 100 iterations of the Generics test without a memory access failure.
Fixes #8210
Closes #8205
Draft as depends on #8171