-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add proposal for using aliases allowing type parameters and additional target types #4452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
cston
wants to merge
5
commits into
dotnet:main
Choose a base branch
from
cston:using-aliases
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev
Previous commit
Updates
- Loading branch information
commit e7d050899b0858c3ff89160e22466f15cda5501e
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -19,8 +19,8 @@ using MyType2<T, U> = T; // ok | |
|
|
||
| Type parameter references in an alias target have the same restrictions as type parameter references in other generic contexts. | ||
| ```C# | ||
| using MyType3<T, U> = T.U; // error: reported at use site only? | ||
| using MyType3<T, U> = T<U>; // error: reported at use site only? | ||
| using MyType3<T, U> = T.U; // error: type or namespace 'T' not found | ||
| using MyType3<T, U> = T<U>; // error: type or namespace 'T<>' not found | ||
| ``` | ||
|
|
||
| The same name may be used for multiple aliases with distinct arity. | ||
|
|
@@ -31,11 +31,12 @@ using MyDictionary<U> = System.Collections.Generic.Dictionary<string, U>; // err | |
| ``` | ||
|
|
||
| A partially bound type is not valid. | ||
| The `using` aliases below are both valid, and the use of `MyList<>` is valid because the expansion `List<>` is an unbound type, but the use of `MyDictionary<>` invalid because `Dictionary<string,>` is a partially bound type. | ||
| ```C# | ||
| using MyList<T> = System.Collections.Generic.List<T>; | ||
| using MyDictionary<T> = System.Collections.Generic.Dictionary<string, T>; | ||
|
|
||
| _ = typef(MyList<>); // ok: 'List<>' | ||
| _ = typeof(MyList<>); // ok: 'List<>' | ||
| _ = typeof(MyDictionary<>); // error: 'Dictionary<string,>' is not valid | ||
| ``` | ||
|
|
||
|
|
@@ -54,6 +55,12 @@ using MaybeNull<T> = T? where T : class; | |
| using Option<T> = System.Nullable<T> where T : struct; | ||
| ``` | ||
|
|
||
| Explicit constraints would also allow restricting the use of the target type. | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Consider referencing the LDM today, notes are up: https://github.com/dotnet/csharplang/blob/master/meetings/2021/LDM-2021-02-22.md |
||
| ```C# | ||
| using ValueTypeList<T> = List<T> where T : struct; | ||
| static void F<T>(ValueTypeList<T> list) { ... } // error: 'T' must be a value type | ||
| ``` | ||
|
|
||
| ### Variance | ||
| Type parameter variance cannot be specified explicitly in the alias declaration, because any resulting variance constraints would not be enforced at the public boundary of the assembly. | ||
|
|
||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider adding an example of a valid use of
MyDictionary. This section is still starting with the words "A partially bound type is not valid.", which doesn't really address the confusion.