Mark Windows-specific APIs

[terrajobst]

No description provided.

[stephentoub]

Someone familiar with WCF will need to comment on this section.

[mconnew]

We have zero api's which are Windows specific.

[terrajobst]

FYI. I've done a run for .NET 5 and the latest Microsoft.Windows.Compatibility pack. Once I've merged the delta, I'll flip this back to api-ready-for-review.

[terrajobst]

@akoeplinger I've rebased out the Excel file 🙂

[jeffhandley]

Suggested change

	* We should run the tool again .NET 5
	* We should run the tool against .NET 5

[jeffhandley]

Per @mconnew's comment, this suggestion will remove the ServiceModel types.

Suggested change

	### System.ServiceModel
	* **ActionNotSupportedException**
	- `.ctor(SerializationInfo, StreamingContext)`
	- `.ctor(String, Exception)`
	* **BasicHttpBinding**
	- `.ctor()`
	- `.ctor(BasicHttpSecurityMode)`
	- `CreateBindingElements()`
	* **BasicHttpsBinding**
	- `.ctor()`
	- `.ctor(BasicHttpsSecurityMode)`
	- `CreateBindingElements()`
	* **ChannelFactory**
	- `.ctor(Binding, EndpointAddress)`
	- `.ctor(ServiceEndpoint)`
	- `.ctor(String)`
	- `.ctor(String, EndpointAddress)`
	- `ApplyConfiguration(String)`
	- `CreateDescription()`
	- `InitializeEndpoint(Binding, EndpointAddress)`
	- `InitializeEndpoint(ServiceEndpoint)`
	- `InitializeEndpoint(String, EndpointAddress)`
	* **ChannelTerminatedException**
	- `.ctor(SerializationInfo, StreamingContext)`
	* **ClientBase**
	- `.ctor()`
	- `.ctor(String)`
	- `.ctor(String, EndpointAddress)`
	- `.ctor(String, String)`
	* **ClientBase+ChannelBase**
	- `EndInvoke(String, Object[], IAsyncResult)`
	* **ClientCredentialsSecurityTokenManager**
	- `CreateSecurityTokenAuthenticator(SecurityTokenRequirement, SecurityTokenResolver)`
	- `CreateSecurityTokenProvider(SecurityTokenRequirement)`
	- `CreateSecurityTokenSerializer(SecurityTokenVersion)`
	* **CommunicationException**
	- `.ctor(SerializationInfo, StreamingContext)`
	* **CommunicationObjectAbortedException**
	- `.ctor(SerializationInfo, StreamingContext)`
	* **CommunicationObjectFaultedException**
	- `.ctor(SerializationInfo, StreamingContext)`
	* **DuplexChannelFactory**
	- `.ctor(InstanceContext, Binding, EndpointAddress)`
	- `.ctor(InstanceContext, Binding, String)`
	- `.ctor(InstanceContext, String)`
	- `.ctor(InstanceContext, String, EndpointAddress)`
	* **DuplexClientBase**
	- `.ctor(InstanceContext)`
	- `.ctor(InstanceContext, String)`
	- `.ctor(InstanceContext, String, EndpointAddress)`
	- `.ctor(InstanceContext, String, String)`
	* **EndpointAddress**
	- `ApplyTo(Message)`
	* **EndpointIdentity**
	- `Equals(Object)`
	- `GetHashCode()`
	* **EndpointNotFoundException**
	- `.ctor(SerializationInfo, StreamingContext)`
	* **FaultException**
	- `.ctor(SerializationInfo, StreamingContext)`
	* **InvalidMessageContractException**
	- `.ctor(SerializationInfo, StreamingContext)`
	* **MessageHeaderException**
	- `.ctor(SerializationInfo, StreamingContext)`
	* **MessageSecurityOverTcp**
	- `get_ClientCredentialType()`
	- `set_ClientCredentialType(MessageCredentialType)`
	* **NetHttpBinding**
	- `CreateBindingElements()`
	* **NetHttpsBinding**
	- `.ctor()`
	- `.ctor(BasicHttpsSecurityMode)`
	- `CreateBindingElements()`
	* **NetTcpBinding**
	- `.ctor(String)`
	- `CreateBindingElements()`
	* **ProtocolException**
	- `.ctor(SerializationInfo, StreamingContext)`
	* **QuotaExceededException**
	- `.ctor(SerializationInfo, StreamingContext)`
	* **ServerTooBusyException**
	- `.ctor(SerializationInfo, StreamingContext)`
	* **ServiceActivationException**
	- `.ctor(SerializationInfo, StreamingContext)`
	### System.ServiceModel.Channels
	* **AddressHeader**
	- `Equals(Object)`
	- `GetHashCode()`
	* **MessageHeaders**
	- `set_To(Uri)`
	* **SecurityBindingElement**
	- `CreateSecureConversationBindingElement(SecurityBindingElement)`
	* **TransportSecurityBindingElement**
	- `GetProperty<T>(BindingContext)`
	* **WebSocketTransportSettings**
	- `get_DisablePayloadMasking()`
	- `set_DisablePayloadMasking(Boolean)`
	### System.ServiceModel.Security
	* **MessageSecurityException**
	- `.ctor(SerializationInfo, StreamingContext)`
	* **SecurityAccessDeniedException**
	- `.ctor(SerializationInfo, StreamingContext)`
	* **SecurityNegotiationException**
	- `.ctor(SerializationInfo, StreamingContext)`
	* **X509ServiceCertificateAuthentication**
	- `set_CertificateValidationMode(X509CertificateValidationMode)`

[stephentoub]

Do we know what caused them to show up here in the first place?

[adamsitnik]

these two are nops and to be consistent with other nops, we should remove them from the list

context: https://github.com/dotnet/designs/pull/138/files#r454448405

Suggested change

	- `EnterDebugMode()`
	- `LeaveDebugMode()`

[adamsitnik]

I can't see a code path where Connect(Int32) throws on Unix.

https://github.com/dotnet/runtime/blob/08643df14054d1273002254c909fa099649ebfcf/src/libraries/System.IO.Pipes/src/System/IO/Pipes/NamedPipeClientStream.cs#L130-L173

https://github.com/dotnet/runtime/blob/08643df14054d1273002254c909fa099649ebfcf/src/libraries/System.IO.Pipes/src/System/IO/Pipes/NamedPipeClientStream.Unix.cs#L20-L67

Suggested change

- `Connect(Int32)`

[adamsitnik]

it's supported on Unix: https://github.com/dotnet/runtime/blob/08643df14054d1273002254c909fa099649ebfcf/src/libraries/System.IO.Pipes/src/System/IO/Pipes/NamedPipeServerStream.Unix.cs#L54-L66

Suggested change

	* **NamedPipeServerStream**
	- `WaitForConnection()`

[adamsitnik]

https://github.com/dotnet/runtime/blob/08643df14054d1273002254c909fa099649ebfcf/src/libraries/System.Net.Sockets/src/System/Net/Sockets/Socket.Unix.cs#L13-L17

Suggested change

	* **Socket**
	- `SetIPProtectionLevel(IPProtectionLevel)`
	* **Socket**
	- `.ctor(SocketInformation)`
	- `SetIPProtectionLevel(IPProtectionLevel)`

[adamsitnik]

https://github.com/dotnet/runtime/blob/1bdcd669e70d687bb0c56fe20aafa7c104b6aa0e/src/libraries/System.IO.FileSystem/src/System/IO/FileSystem.Unix.cs#L50-L58

Suggested change

	### System.IO.FileSystem
	* **File**
	- `Decrypt(string)`
	- `Encrypt(string)`

[adamsitnik]

FWIW I've done some simple manual search of keyword "PlatformNotSupportedException" in *Unix.cs files and found only 2 things that were not on the list and provided a suggestion that adds them. IMO the list is complete now.

My PR is ready dotnet/runtime#39265

[terrajobst]

Video

• The proposal looks good.
• We should consider a diagnostic to warn on typos in the OS name, e.g. [MinimumOSPlatform("windos7.0")]