-
Notifications
You must be signed in to change notification settings - Fork 167
Change the configuration to use file per arch #248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
vitek-karas
merged 5 commits into
dotnet:main
from
vitek-karas:InstallLocationMultiFile
Sep 24, 2021
Merged
Change the configuration to use file per arch #248
vitek-karas
merged 5 commits into
dotnet:main
from
vitek-karas:InstallLocationMultiFile
Sep 24, 2021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the way multi-arch configuration files are written. Use one file per architecture (instead of one file with multiple lines in it). This makes it much simpler for installers to read and write these configuration files. It also somewhat simplified the product as it doesn't need as complex parsing logic. Minor cleanup in other areas of the doc.
Member
Author
mateoatr
reviewed
Sep 21, 2021
ericstj
reviewed
Sep 21, 2021
Co-authored-by: Mateo Torres-Ruiz <[email protected]> Co-authored-by: Eric StJohn <[email protected]>
ericstj
approved these changes
Sep 22, 2021
richlander
approved these changes
Sep 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the way multi-arch configuration files are written. Use one file per architecture (instead of one file with multiple lines in it). This makes it much simpler for installers to read and write these configuration files. It also somewhat simplified the product as it doesn't need as complex parsing logic.
Minor cleanup in other areas of the doc.