Skip to content

Add POH to SOS commands #1228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davmason merged 6 commits into from
Jun 18, 2020
+2,977 −2,412
Merged

Add POH to SOS commands #1228

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ffedce2
SOS changes for pinned object heap
davmason Jun 10, 2020
46a6cd8
code review feedback
davmason Jun 15, 2020
2b20597
updates from runtime changes
davmason Jun 16, 2020
6a51795
fix incorrect assert
davmason Jun 16, 2020
8c8b69f
fix off by 1 error, DacpGcHeapDetails has an array of size 7 (DAC_NUM…
davmason Jun 17, 2020
83f956e
fix formatting with !gcheapstat and objectiterator::nextsegment when …
davmason Jun 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix off by 1 error, DacpGcHeapDetails has an array of size 7 (DAC_NUM… 
…BERGENERATIONS + 3) but the runtime only returns 6 items.
  • Loading branch information
@davmason
davmason committed Jun 17, 2020
commit 8c8b69fe951eb3a823769c132f91d289ea1cec7b
4 changes: 3 additions & 1 deletion src/SOS/Strike/util.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -406,7 +406,7 @@ class GCHeapDetails
_ASSERTE(hr != S_FALSE);

// We couldn't get any data from the newer APIs, so fall back to the original data
memcpy(data, &(heap.finalization_fill_pointers), sizeof(CLRDATA_ADDRESS) * (DAC_NUMBERGENERATIONS + 3));
memcpy(data, &(heap.finalization_fill_pointers), sizeof(CLRDATA_ADDRESS) * (DAC_NUMBERGENERATIONS + 2));
}
}

Expand All @@ -430,11 +430,13 @@ class GCHeapDetails
if (generation_table != NULL)
{
delete[] generation_table;
generation_table = NULL;
}

if (finalization_fill_pointers != NULL)
{
delete[] finalization_fill_pointers;
finalization_fill_pointers = NULL;
}
}

Expand Down