[WIP] Generational aware analysis (diagnostics part) #1338
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikem8361
reviewed
Jul 13, 2020
| Process process = Process.GetProcessById(processId); | ||
| var client = new DiagnosticsClient(processId); | ||
|
|
||
| Windows.CollectDump(process, output, type); |
Contributor
There was a problem hiding this comment.
The problem with this change is that now dotnet-dump collect on Windows won't work with older runtimes (<= 2.2) and it did before. May be it isn't that important because dotnet-dump collect on xplat only works runtimes > 2.2 and your change is needed to provide the condition on Windows.
dotnet-dump could catch that the client.WriteDump fails on the unsupported Windows runtimes, but the exception is inconsistent/difficult than xplat. I think it is something like TimeoutException on Windows and PlatformNotSupportedException on xplat.
/cc: @josalem on the client assembly exception difference.
cshung
force-pushed
the
public/dev/andrewau/generational-aware-diagnostics
branch
from
b4757db to
c265294
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the diagnostics part of the generational aware analysis.
The runtime part can be found here.