Skip to content

Hide counter argument and update --counters option description #1770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sywhang merged 3 commits into from
Nov 30, 2020
Merged

Hide counter argument and update --counters option description #1770

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
617e2e5
Hide counter argument and update --counters option description
sywhang Nov 26, 2020
7a88125
fix description
sywhang Nov 26, 2020
f703b95
remove arity
sywhang Nov 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/Tools/dotnet-counters/Program.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,16 +90,16 @@ private static Option ExportFileNameOption() =>
private static Option CounterOption() =>
new Option(
alias: "--counters",
description: "List of counter providers.")
description: "A comma-separated list of counter providers. Counter providers can be specified provider_name[:counter_name]. If the provider_name is used without a qualifying counter_name then all counters will be shown. To discover provider and counter names, use the list command.")
{
Argument = new Argument<string>(name: "counters", getDefaultValue: () => "System.Runtime")
};

private static Argument CounterList() =>
new Argument<List<string>>(name: "counter_list", getDefaultValue: () => new List<string>() )
new Argument<List<string>>(name: "counter_list", getDefaultValue: () => new List<string>())
Copy link

@jonsequitur jonsequitur Nov 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The getDefaultValue shouldn't be necessary here.

{
Description = @"A space separated list of counters. Counters can be specified provider_name[:counter_name]. If the provider_name is used without a qualifying counter_name then all counters will be shown. To discover provider and counter names, use the list command.",
Arity = ArgumentArity.ZeroOrMore
IsHidden = true
};

private static Command ListCommand() =>
Expand Down