Skip to content

Allow for runtimelab to build Microsoft.Diagnostics.NETCore.Client #3139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hoyosjs merged 3 commits into from
Jun 22, 2022
Merged

Allow for runtimelab to build Microsoft.Diagnostics.NETCore.Client #3139

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ead0d82
Allow for runtimelab to build Microsoft.Diagnostics.NETCore.Client
hoyosjs Jun 22, 2022
32ab044
Update eng/SourceBuild.props
hoyosjs Jun 22, 2022
a96d131
Update eng/SourceBuild.props
hoyosjs Jun 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,5 +16,6 @@
<RepositoryType>git</RepositoryType>
<PackageLicenseExpression>MIT</PackageLicenseExpression>
<EnableSourceControlManagerQueries>true</EnableSourceControlManagerQueries>
<GitHubRepositoryName>diagnostics</GitHubRepositoryName>
</PropertyGroup>
</Project>
1 change: 0 additions & 1 deletion eng/SourceBuild.props
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
<Project>

<PropertyGroup>
<GitHubRepositoryName>diagnostics</GitHubRepositoryName>
Copy link
Contributor

@mikem8361 mikem8361 Jun 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the source build leg is failing because this file doesn't include ../Directory.Build.props?

<SourceBuildManagedOnly>true</SourceBuildManagedOnly>
</PropertyGroup>

Expand Down
6 changes: 4 additions & 2 deletions src/Microsoft.Diagnostics.NETCore.Client/Microsoft.Diagnostics.NETCore.Client.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,11 @@
<GenerateDocumentationFile>true</GenerateDocumentationFile>
<IncludeSymbols>true</IncludeSymbols>
<IsShipping>true</IsShipping>
<BuildingOutsideDiagnostics>false</BuildingOutsideDiagnostics>
<BuildingOutsideDiagnostics Condition="'$(GitHubRepositoryName)' != 'diagnostics'">true</BuildingOutsideDiagnostics>
</PropertyGroup>

<PropertyGroup Condition="'$(GitHubRepositoryName)' == 'runtime'">
<PropertyGroup Condition="$(BuildingOutsideDiagnostics)">
<DefineConstants>$(DefineConstants);DIAGNOSTICS_RUNTIME</DefineConstants>
<NoWarn>CS1591,CS8073,CS0162</NoWarn>
</PropertyGroup>
Expand All @@ -36,6 +38,6 @@
</ItemGroup>

<ItemGroup>
<Compile Condition="'$(GitHubRepositoryName)' == 'runtime'" Include="**/*.cs" />
<Compile Condition="$(BuildingOutsideDiagnostics)" Include="**/*.cs" />
</ItemGroup>
</Project>