Skip to content

Enable int overflow/underflow checking #3361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mikem8361 merged 3 commits into from
Sep 9, 2022
Merged

Enable int overflow/underflow checking #3361

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bb1215a
Enable int overflow/underflow checking
Sep 8, 2022
6963156
Fix SOS test failure
Sep 9, 2022
94bfbe4
Fix x86 SOS test failures
Sep 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix x86 SOS test failures
  • Loading branch information
Mike McLaughlin committed Sep 9, 2022
commit 94bfbe4637d18961c7b4401fcc1d6b17d39e57ff
2 changes: 1 addition & 1 deletion src/Microsoft.Diagnostics.DebugServices.Implementation/ImageMappingMemoryService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,7 +225,7 @@ private void ApplyRelocations(IModule module, PEReader reader, int dataVA, byte[
PEMemoryBlock relocations = reader.GetSectionData(".reloc");
if (relocations.Length > 0)
{
ulong baseDelta = module.ImageBase - reader.PEHeaders.PEHeader.ImageBase;
ulong baseDelta = unchecked(module.ImageBase - reader.PEHeaders.PEHeader.ImageBase);
#if TRACE_VERBOSE
Trace.TraceInformation("ApplyRelocations: dataVA {0:X8} dataCB {1} baseDelta: {2:X16}", dataVA, data.Length, baseDelta);
#endif
Expand Down