Skip to content

Fix overflow exception in Microsoft.Diagnostics.Monitoring #3400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mikem8361 merged 1 commit into from
Sep 20, 2022
Merged

Fix overflow exception in Microsoft.Diagnostics.Monitoring #3400

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 23 additions & 20 deletions src/Tools/dotnet-gcdump/DotNetHeapDump/Graph.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -882,35 +882,38 @@ internal static int ReadCompressedInt(SegmentedMemoryStreamReader reader)

internal static void WriteCompressedInt(SegmentedMemoryStreamWriter writer, int value)
{
if (value << 25 >> 25 == value)
unchecked
{
goto oneByte;
}
if (value << 25 >> 25 == value)
{
goto oneByte;
}

if (value << 18 >> 18 == value)
{
goto twoBytes;
}
if (value << 18 >> 18 == value)
{
goto twoBytes;
}

if (value << 11 >> 11 == value)
{
goto threeBytes;
}
if (value << 11 >> 11 == value)
{
goto threeBytes;
}

if (value << 4 >> 4 == value)
{
goto fourBytes;
}
if (value << 4 >> 4 == value)
{
goto fourBytes;
}

writer.Write((byte)((value >> 28) | 0x80));
writer.Write((byte)((value >> 28) | 0x80));
fourBytes:
writer.Write((byte)((value >> 21) | 0x80));
writer.Write((byte)((value >> 21) | 0x80));
threeBytes:
writer.Write((byte)((value >> 14) | 0x80));
writer.Write((byte)((value >> 14) | 0x80));
twoBytes:
writer.Write((byte)((value >> 7) | 0x80));
writer.Write((byte)((value >> 7) | 0x80));
oneByte:
writer.Write((byte)(value & 0x7F));
writer.Write((byte)(value & 0x7F));
}
}

internal NodeIndex m_index;
Expand Down