Fix/disable nullable warnings treated as errors with newer SDKs insta…

…lled (#3616)

* Fix/disable nullable warnings treated as errors with newer SDKs installed

* Missed a test cs file

src/Microsoft.Diagnostics.ExtensionCommands/DumpAsyncCommand.cs

@@ -459,7 +459,7 @@ bool ShouldIncludeStack(AsyncObject obj)
             // <summary>Outputs a line of information for each instance field on the object.</summary>
             void RenderFields(IAddressableTypedEntity? obj, int depth)
             {
-                if (obj is not null)
+                if (obj?.Type is not null)
                 {
                     string depthTab = new string(' ', depth * TabWidth);
 
@@ -489,33 +489,36 @@ void RenderFields(IAddressableTypedEntity? obj, int depth)
             // <summary>Gets a printable description for the specified object.</summary>
             string Describe(ClrObject obj)
             {
-                // Default the description to the type name.
-                string description = obj.Type.Name;
-
-                if (IsStateMachineBox(obj.Type))
+                string description = string.Empty;
+                if (obj.Type?.Name is not null)
                 {
-                    // Remove the boilerplate box type from the name.
-                    int pos = description.IndexOf("StateMachineBox<", StringComparison.Ordinal);
-                    if (pos >= 0)
+                    // Default the description to the type name.
+                    description = obj.Type.Name;
+
+                    if (IsStateMachineBox(obj.Type))
                     {
-                        ReadOnlySpan<char> slice = description.AsSpan(pos + "StateMachineBox<".Length);
-                        slice = slice.Slice(0, slice.Length - 1); // remove trailing >
-                        description = slice.ToString();
+                        // Remove the boilerplate box type from the name.
+                        int pos = description.IndexOf("StateMachineBox<", StringComparison.Ordinal);
+                        if (pos >= 0)
+                        {
+                            ReadOnlySpan<char> slice = description.AsSpan(pos + "StateMachineBox<".Length);
+                            slice = slice.Slice(0, slice.Length - 1); // remove trailing >
+                            description = slice.ToString();
+                        }
                     }
-                }
-                else if (TryGetValidObjectField(obj, "m_action", out ClrObject taskDelegate))
-                {
-                    // If we can figure out what the task's delegate points to, append the method signature.
-                    if (TryGetMethodFromDelegate(runtime, taskDelegate, out ClrMethod? method))
+                    else if (TryGetValidObjectField(obj, "m_action", out ClrObject taskDelegate))
+                    {
+                        // If we can figure out what the task's delegate points to, append the method signature.
+                        if (TryGetMethodFromDelegate(runtime, taskDelegate, out ClrMethod? method))
+                        {
+                            description = $"{description} {{{method!.Signature}}}";
+                        }
+                    }
+                    else if (obj.Address != 0 && taskCompletionSentinel.Address == obj.Address)
                     {
-                        description = $"{description} {{{method!.Signature}}}";
+                        description = "TaskCompletionSentinel";
                     }
                 }
-                else if (obj.Address != 0 && taskCompletionSentinel.Address == obj.Address)
-                {
-                    description = "TaskCompletionSentinel";
-                }
-
                 return description;
             }
 
@@ -527,14 +530,17 @@ bool IncludeInOutput(ClrObject obj)
                     return false;
                 }
 
-                if (MethodTableAddress is ulong mt && obj.Type.MethodTable != mt)
+                if (obj.Type is not null)
                 {
-                    return false;
-                }
+                    if (MethodTableAddress is ulong mt && obj.Type.MethodTable != mt)
+                    {
+                        return false;
+                    }
 
-                if (NameSubstring is not null && !obj.Type.Name.Contains(NameSubstring))
-                {
-                    return false;
+                    if (NameSubstring is not null && obj.Type.Name is not null && !obj.Type.Name.Contains(NameSubstring))
+                    {
+                        return false;
+                    }
                 }
 
                 return true;
@@ -655,37 +661,42 @@ Dictionary<ClrObject, AsyncObject> CollectObjects()
             // </remarks>
             void AddContinuation(ClrObject continuation, List<ClrObject> continuations)
             {
-                if (continuation.Type.Name.StartsWith("System.Collections.Generic.List<", StringComparison.Ordinal))
+                if (continuation.Type is not null)
                 {
-                    if (continuation.Type.GetFieldByName("_items") is ClrInstanceField itemsField)
+                    if (continuation.Type.Name is not null &&
+                        continuation.Type.Name.StartsWith("System.Collections.Generic.List<", StringComparison.Ordinal))
                     {
-                        ClrObject itemsObj = itemsField.ReadObject(continuation.Address, interior: false);
-                        if (!itemsObj.IsNull)
+                        if (continuation.Type.GetFieldByName("_items") is ClrInstanceField itemsField)
                         {
-                            ClrArray items = itemsObj.AsArray();
-                            if (items.Rank == 1)
+                            ClrObject itemsObj = itemsField.ReadObject(continuation.Address, interior: false);
+                            if (!itemsObj.IsNull)
                             {
-                                for (int i = 0; i < items.Length; i++)
+                                ClrArray items = itemsObj.AsArray();
+                                if (items.Rank == 1)
                                 {
-                                    if (items.GetObjectValue(i) is ClrObject { IsValid: true } c)
+                                    for (int i = 0; i < items.Length; i++)
                                     {
-                                        continuations.Add(ResolveContinuation(c));
+                                        if (items.GetObjectValue(i) is ClrObject { IsValid: true } c)
+                                        {
+                                            continuations.Add(ResolveContinuation(c));
+                                        }
                                     }
                                 }
                             }
                         }
                     }
-                }
-                else
-                {
-                    continuations.Add(continuation);
+                    else
+                    {
+                        continuations.Add(continuation);
+                    }
                 }
             }
 
             // <summary>Tries to get the object contents of a Task's continuations field</summary>
             bool TryGetContinuation(ClrObject obj, out ClrObject continuation)
             {
-                if (obj.Type.GetFieldByName("m_continuationObject") is ClrInstanceField continuationObjectField &&
+                if (obj.Type is not null &&
+                    obj.Type.GetFieldByName("m_continuationObject") is ClrInstanceField continuationObjectField &&
                     continuationObjectField.ReadObject(obj.Address, interior: false) is ClrObject { IsValid: true } continuationObject)
                 {
                     continuation = ResolveContinuation(continuationObject);
@@ -888,7 +899,7 @@ private void WriteCodeLink(ulong address)
         }
 
         /// <summary>Gets whether the specified type is an AsyncStateMachineBox{T}.</summary>
-        private static bool IsStateMachineBox(ClrType type)
+        private static bool IsStateMachineBox(ClrType? type)
         {
             // Ideally we would compare the metadata token and module for the generic template for the type,
             // but that information isn't fully available via ClrMd, nor can it currently find DebugFinalizableAsyncStateMachineBox

src/SOS/SOS.UnitTests/SOS.cs

@@ -14,6 +14,11 @@
 using Xunit.Abstractions;
 using Xunit.Extensions;
 
+// Newer SDKs flag MemberData(nameof(Configurations)) with this error
+// Avoid unnecessary zero-length array allocations.  Use Array.Empty<object>() instead.
+#pragma warning disable CA1825 
+
+[Collection("Windows Dump Generation")]
 public class SOS
 {
     public SOS(ITestOutputHelper output)

src/tests/DbgShim.UnitTests/DbgShimTests.cs

@@ -20,6 +20,10 @@
 using Xunit.Abstractions;
 using Xunit.Extensions;
 
+// Newer SDKs flag MemberData(nameof(Configurations)) with this error
+// Avoid unnecessary zero-length array allocations.  Use Array.Empty<object>() instead.
+#pragma warning disable CA1825 
+
 namespace Microsoft.Diagnostics
 {
     public class DbgShimTests : IDisposable

src/tests/Microsoft.Diagnostics.DebugServices.UnitTests/DebugServicesTests.cs

@@ -11,6 +11,10 @@
 using Xunit.Abstractions;
 using Xunit.Extensions;
 
+// Newer SDKs flag MemberData(nameof(Configurations)) with this error
+// Avoid unnecessary zero-length array allocations.  Use Array.Empty<object>() instead.
+#pragma warning disable CA1825 
+
 namespace Microsoft.Diagnostics.DebugServices.UnitTests
 {
     public class DebugServicesTests : IDisposable

src/tests/Microsoft.Diagnostics.Monitoring.EventPipe/EventCounterPipelineUnitTests.cs

@@ -13,6 +13,10 @@
 using Xunit.Extensions;
 using TestRunner = Microsoft.Diagnostics.CommonTestRunner.TestRunner;
 
+// Newer SDKs flag MemberData(nameof(Configurations)) with this error
+// Avoid unnecessary zero-length array allocations.  Use Array.Empty<object>() instead.
+#pragma warning disable CA1825 
+
 namespace Microsoft.Diagnostics.Monitoring.EventPipe.UnitTests
 {
     public class EventCounterPipelineUnitTests

src/tests/Microsoft.Diagnostics.Monitoring.EventPipe/EventCounterTriggerTests.cs

@@ -10,14 +10,17 @@
 using System.Collections.Generic;
 using System.ComponentModel.DataAnnotations;
 using System.Globalization;
-using System.Runtime.InteropServices;
 using System.Threading;
 using System.Threading.Tasks;
 using Xunit;
 using Xunit.Abstractions;
 using Xunit.Extensions;
 using TestRunner = Microsoft.Diagnostics.CommonTestRunner.TestRunner;
 
+// Newer SDKs flag MemberData(nameof(Configurations)) with this error
+// Avoid unnecessary zero-length array allocations.  Use Array.Empty<object>() instead.
+#pragma warning disable CA1825 
+
 namespace Microsoft.Diagnostics.Monitoring.EventPipe.UnitTests
 {
     public class EventCounterTriggerTests

src/tests/Microsoft.Diagnostics.Monitoring.EventPipe/EventLogsPipelineUnitTests.cs

@@ -18,6 +18,10 @@
 using Xunit.Extensions;
 using TestRunner = Microsoft.Diagnostics.CommonTestRunner.TestRunner;
 
+// Newer SDKs flag MemberData(nameof(Configurations)) with this error
+// Avoid unnecessary zero-length array allocations.  Use Array.Empty<object>() instead.
+#pragma warning disable CA1825 
+
 namespace Microsoft.Diagnostics.Monitoring.EventPipe.UnitTests
 {
     public class EventLogsPipelineUnitTests

src/tests/Microsoft.Diagnostics.Monitoring.EventPipe/EventTracePipelineUnitTests.cs

@@ -17,6 +17,10 @@
 using Xunit.Extensions;
 using TestRunner = Microsoft.Diagnostics.CommonTestRunner.TestRunner;
 
+// Newer SDKs flag MemberData(nameof(Configurations)) with this error
+// Avoid unnecessary zero-length array allocations.  Use Array.Empty<object>() instead.
+#pragma warning disable CA1825 
+
 namespace Microsoft.Diagnostics.Monitoring.EventPipe.UnitTests
 {
     public class EventTracePipelineUnitTests

src/tests/Microsoft.Diagnostics.NETCore.Client/EventPipeSessionTests.cs

@@ -14,6 +14,10 @@
 using Xunit.Extensions;
 using TestRunner = Microsoft.Diagnostics.CommonTestRunner.TestRunner;
 
+// Newer SDKs flag MemberData(nameof(Configurations)) with this error
+// Avoid unnecessary zero-length array allocations.  Use Array.Empty<object>() instead.
+#pragma warning disable CA1825 
+
 namespace Microsoft.Diagnostics.NETCore.Client
 {
     public class EventPipeSessionTests

src/tests/Microsoft.Diagnostics.NETCore.Client/GetProcessEnvironmentTests.cs

@@ -10,6 +10,10 @@
 using Xunit.Extensions;
 using TestRunner = Microsoft.Diagnostics.CommonTestRunner.TestRunner;
 
+// Newer SDKs flag MemberData(nameof(Configurations)) with this error
+// Avoid unnecessary zero-length array allocations.  Use Array.Empty<object>() instead.
+#pragma warning disable CA1825 
+
 namespace Microsoft.Diagnostics.NETCore.Client
 {
     public class ProcessEnvironmentTests

src/tests/Microsoft.Diagnostics.NETCore.Client/GetProcessInfoTests.cs

@@ -13,6 +13,10 @@
 using Xunit.Extensions;
 using TestRunner = Microsoft.Diagnostics.CommonTestRunner.TestRunner;
 
+// Newer SDKs flag MemberData(nameof(Configurations)) with this error
+// Avoid unnecessary zero-length array allocations.  Use Array.Empty<object>() instead.
+#pragma warning disable CA1825 
+
 namespace Microsoft.Diagnostics.NETCore.Client
 {
     public class GetProcessInfoTests

src/tests/Microsoft.Diagnostics.NETCore.Client/GetPublishedProcessesTests.cs

@@ -5,14 +5,17 @@
 using Microsoft.Diagnostics.TestHelpers;
 using System;
 using System.Collections.Generic;
-using System.Runtime.InteropServices;
 using System.Threading;
 using System.Threading.Tasks;
 using Xunit;
 using Xunit.Abstractions;
 using Xunit.Extensions;
 using TestRunner = Microsoft.Diagnostics.CommonTestRunner.TestRunner;
 
+// Newer SDKs flag MemberData(nameof(Configurations)) with this error
+// Avoid unnecessary zero-length array allocations.  Use Array.Empty<object>() instead.
+#pragma warning disable CA1825 
+
 namespace Microsoft.Diagnostics.NETCore.Client
 {
 

src/tests/Microsoft.Diagnostics.NETCore.Client/ReversedServerTests.cs

@@ -19,6 +19,10 @@
 using Xunit.Extensions;
 using TestRunner = Microsoft.Diagnostics.CommonTestRunner.TestRunner;
 
+// Newer SDKs flag MemberData(nameof(Configurations)) with this error
+// Avoid unnecessary zero-length array allocations.  Use Array.Empty<object>() instead.
+#pragma warning disable CA1825 
+
 namespace Microsoft.Diagnostics.NETCore.Client
 {
     public class ReversedServerTests

src/tests/dotnet-counters/JSONExporterTests.cs

@@ -4,12 +4,13 @@
 
 using System;
 using System.IO;
-using System.Collections.Generic;
 using Xunit;
 using Microsoft.Diagnostics.Tools.Counters.Exporters;
 using Newtonsoft.Json;
 using Microsoft.Diagnostics.Tools.Counters;
 
+#pragma warning disable CA1507 // Use nameof to express symbol names
+
 namespace DotnetCounters.UnitTests
 {
     /// <summary>

src/tests/dotnet-trace/ChildProcessTests.cs

@@ -12,9 +12,12 @@
 using Xunit.Extensions;
 using TestRunner = Microsoft.Diagnostics.CommonTestRunner.TestRunner;
 
+// Newer SDKs flag MemberData(nameof(Configurations)) with this error
+// Avoid unnecessary zero-length array allocations.  Use Array.Empty<object>() instead.
+#pragma warning disable CA1825 
+
 namespace Microsoft.Diagnostics.Tools.Trace
 {
-
     public class ChildProcessTests
     {
         public static IEnumerable<object[]> Configurations => TestRunner.Configurations;