Update to build with net8, remove net6 and start net10 testing #5103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 11, 2024 15:19
Suppress errors/warnings/suggestions
tommcdon
reviewed
Dec 13, 2024
src/tests/DbgShim.UnitTests/ConfigFiles/Windows/Debugger.Tests.Config.txt
Outdated
Show resolved
Hide resolved
tommcdon
reviewed
Dec 13, 2024
src/SOS/SOS.UnitTests/ConfigFiles/Unix/Debugger.Tests.Config.txt
Outdated
Show resolved
Hide resolved
tommcdon
approved these changes
Dec 13, 2024
Member
tommcdon
left a comment
tommcdon
left a comment
There was a problem hiding this comment.
Overall LGTM, left a couple comments for your review.
hoyosjs
approved these changes
Dec 13, 2024
Contributor
Author
|
I hit null ref here when there was no runtime. Just a little clean up.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.