Skip to content

Add a diagnostic port option to dotnet-dump #5307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hoyosjs merged 4 commits into from
Mar 7, 2025
Merged

Add a diagnostic port option to dotnet-dump #5307

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
95b059f
Add a diagnostic port option to dotnet-dump
zachcmadsen Mar 3, 2025
83f7efe
Add empty dsrouter argument
zachcmadsen Mar 3, 2025
769a51b
Remove dsrouter parameter and pass an empty string directly
zachcmadsen Mar 3, 2025
ef344f8
Apply suggestions from code review
hoyosjs Mar 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Apply suggestions from code review
  • Loading branch information
@hoyosjs
hoyosjs authored Mar 7, 2025
commit ef344f84fdc98382e836a5fd59120fb6dd202ffc
2 changes: 1 addition & 1 deletion src/Tools/dotnet-dump/Program.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ private static Command CollectCommand()
private static readonly Option<string> DiagnosticPortOption =
new("--diagnostic-port", "--dport")
{
Description = "The path to a diagnostic port to be used."
Description = "The path to a diagnostic port to be used. Must be a runtime connect port."
};

private static Command AnalyzeCommand()
Expand Down
Loading