Remove counter_list support from dotnet-counters #5318
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've had --counters for a while, and handling two argument lists (one for counter_list, and the other one for the launch params) is pretty gnarly with the new version of system.commandline as dotnet/command-line-api@4b60585 dropped the flag that enabled this parsing mode. Since dotnet#1770 we've said that the option was hidden, and we'd eventually deprecate it. This commit removes the counter_list argument from dotnet-counters and we assume that all arguments are for the launch params.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've had --counters for a while, and handling two argument lists (one for counter_list,
and the other one for the launch params) is pretty gnarly with the new version of system.commandline
as dotnet/command-line-api@4b60585 dropped the
flag that enabled this parsing mode.
Since #1770 we've said that the option was hidden, and we'd eventually deprecate it.
This commit removes the counter_list argument from dotnet-counters and we assume that all arguments are
for the launch params.
Fixes #5317