Move dotnet-test into the artifacts folder #5602
Conversation
steveisok
left a comment
steveisok
left a comment
There was a problem hiding this comment.
LGTM as long as we're all aligned.
| <Import ConfigFile="Debugger.Tests.Common.txt" /> | ||
| <DotNetRoot Condition="'$(TargetArchitecture)' != 'x86'">$(RepoRootDir)\.dotnet-test</DotNetRoot> | ||
| <DotNetRoot Condition="'$(TargetArchitecture)' == 'x86'">$(RepoRootDir)\.dotnet-test\x86</DotNetRoot> | ||
| <DotNetRoot>$(ArtifactsDir)\runtime</DotNetRoot> |
There was a problem hiding this comment.
Previously we had a specialized directory for x86. Is that specialization no longer needed? It appears like someone testing both x64 and x86 would have the file paths collide in the same directory and the test wouldn't work.
There was a problem hiding this comment.
My understanding is that this was implemented to mimic actual dotnet installs. @hoyosjs mentioned that on other platforms there are subfolders with different architectures as well (MacOS uses /x64).
Given this is intended to be used as a test asset, I didn't think we benefitted from copying this behavior.
eng/InstallRuntimes.proj
Outdated
| $(VersionsPropsPath) - path of Versions.props | ||
| From Directory.Build.props: | ||
| $(ArtifactsRuntimeDir) - artifacts\runtime directory |
There was a problem hiding this comment.
The new directory name of 'runtime' feels a bit ambiguous to me. "dotnet-test" conveyed both that the files were in the dotnet layout (as opposed to CORE_ROOT layout) and also that the files were a test asset.
There was a problem hiding this comment.
I'll change the folder to artifacts/dotnet-test
| $(RepositoryEngineeringDir) - the "eng" directory | ||
| $(VersionsPropsPath) - path of Versions.props | ||
| From Directory.Build.props: |
There was a problem hiding this comment.
The only thing is before we supported SxS testing of x86 and x64. I am not married to this, if you're ok with that.
4 participants
Currently
.dotnet-testis located in the repo root. This presents challenges when moving tests to helix as the test root has config files used during testing.I moved the dotnet install to
/artifacts/dotnet-testwhich can be packaged and sent up to helix.