Skip to content

Add uncompressed windbg manifest generation to SOS build #5603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hoyosjs merged 1 commit into from
Oct 21, 2025
Merged

Add uncompressed windbg manifest generation to SOS build #5603

hoyosjs merged 1 commit into from
Oct 21, 2025

Conversation

@hoyosjs
Copy link
Member

@hoyosjs hoyosjs commented Oct 21, 2025

  • Use file-based app to generate manifests for SOS packages
  • Generate both regular and uncompressed manifest formats

@hoyosjs hoyosjs requested a review from a team as a code owner October 21, 2025 02:03
@hoyosjs hoyosjs force-pushed the juhoyosa/update-sos-manifest-logic branch from cf88ec1 to 624dd4b Compare October 21, 2025 06:10
@hoyosjs hoyosjs enabled auto-merge (squash) October 21, 2025 08:59
noahfalk
noahfalk approved these changes Oct 21, 2025
View reviewed changes
Copy link
Member

@noahfalk noahfalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A src\SOS\SOS.Package\README.md would be very useful to describe what consumes the manifest this generates. If possible a link to a doc or example of the format would be helpful.

It would also be helpful if the PR description explicitly mentions this is a windbg manifest.

@hoyosjs hoyosjs merged commit 4cf9d90 into dotnet:main Oct 21, 2025
19 checks passed
@noahfalk noahfalk changed the title Add uncompressed manifest generation to SOS build Add uncompressed windbg manifest generation to SOS build Oct 21, 2025
@hoyosjs hoyosjs deleted the juhoyosa/update-sos-manifest-logic branch October 21, 2025 09:21
@hoyosjs hoyosjs mentioned this pull request Oct 21, 2025
Closed
This was referenced Oct 22, 2025
Merged
Merged
@hoyosjs hoyosjs mentioned this pull request Oct 24, 2025
Merged
hoyosjs added a commit to hoyosjs/diagnostics that referenced this pull request Oct 24, 2025
@hoyosjs
Add uncompressed manifest generation to SOS build (dotnet#5603)
2aa34d3 
- Use file-based app to generate manifests for SOS packages
- Generate both regular and uncompressed manifest formats
hoyosjs added a commit that referenced this pull request Oct 25, 2025
@hoyosjs
Backport select changes and fixes (#5615)
9e46ef4 
- **Add uncompressed manifest generation to SOS build (#5603)**
- **Allow to run diagnostics pipeline in build-only mode (#5613)**
- **Fix packaging issues in SOS containing packages (#5611)**
@github-actions github-actions bot locked and limited conversation to collaborators Nov 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@noahfalk noahfalk noahfalk approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hoyosjs @noahfalk