Skip to content

fix: use textContent to get header titles #10790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yufeih merged 2 commits into from
Sep 2, 2025
Merged

fix: use textContent to get header titles #10790

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f2ce8a9
fix: use `textContent` to get header titles
Aug 21, 2025
77bc0d8
Merge branch 'main' into main
yufeih Sep 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix: use textContent to get header titles 
The modern template currently uses `innerText` to get the text from h2
and h3 tags for the "In This Article" section of the affix. However,
this can cause links with empty text content to be generated for headers
which are not visible at the moment the navigation is generated, such as
those in a `<details>` element. Using `textContent` instead will still
properly retrieve the text from these headers.
  • Loading branch information
Preston Petrie committed Aug 21, 2025
commit f2ce8a96d97df0b4115baa04b3ccfd957e4f3b5c
4 changes: 2 additions & 2 deletions templates/modern/src/nav.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,8 +127,8 @@ function inThisArticle(): TemplateResult {
return html`
<h5 class="border-bottom">${loc('inThisArticle')}</h5>
<ul>${headings.map(h => h.tagName === 'H2'
? html`<li><a class="link-body-emphasis" href="#${h.id}">${breakWordLit(h.innerText)}</a></li>`
: html`<li><a class="link-secondary" href="#${h.id}">${breakWordLit(h.innerText)}</a></li>`
? html`<li><a class="link-body-emphasis" href="#${h.id}">${breakWordLit(h.textContent)}</a></li>`
: html`<li><a class="link-secondary" href="#${h.id}">${breakWordLit(h.textContent)}</a></li>`
)}</ul>`
}
}
Expand Down
Loading