Skip to content

refactor: re-organize dotnet reference generation #9258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yufeih merged 15 commits into from
Sep 30, 2023
Merged

refactor: re-organize dotnet reference generation #9258

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
aed93fe
wip
yufeih Sep 28, 2023
aed1b2f
refactor: re-organize dotnet reference generation
yufeih Sep 30, 2023
efa4714
test(snapshot): update snapshots for 797dcacebecf705f139df548f967a6d1…
yufeih Sep 30, 2023
122c372
Add back md snapshots
yufeih Sep 30, 2023
a801e46
minor adjustments
yufeih Sep 30, 2023
5c9ffcb
Merge branch 'refactor' of https://github.com/dotnet/docfx into refactor
yufeih Sep 30, 2023
5d0314e
test(snapshot): update snapshots for d862373cd6bd76b67698303d52c6d060…
yufeih Sep 30, 2023
8b65472
markdown escape
yufeih Sep 30, 2023
1d83450
fix tests
yufeih Sep 30, 2023
c3ace41
Merge branch 'refactor' of https://github.com/dotnet/docfx into refactor
yufeih Sep 30, 2023
4408444
test(snapshot): update snapshots for 2383aaae35116e3f77c8e659194fe9c5…
yufeih Sep 30, 2023
0e5848b
adjust docs
yufeih Sep 30, 2023
25a89d0
Merge branch 'refactor' of https://github.com/dotnet/docfx into refactor
yufeih Sep 30, 2023
f4b8a57
update escape chars
yufeih Sep 30, 2023
240cc66
test(snapshot): update snapshots for 67d13fb797d648e9c1e0a0f1fe2d5f03…
yufeih Sep 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix tests
  • Loading branch information
@yufeih
yufeih committed Sep 30, 2023
commit 1d8345038aee137306d37a2a01309d05f7c4cdaf
4 changes: 2 additions & 2 deletions test/Docfx.Dotnet.Tests/SymbolUrlResolverUnitTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,13 +85,13 @@ public static void GetPdbSourceLinkUrlTest()
Assert.NotNull(type);
var compilationLink = ReplaceSHA(SymbolUrlResolver.GetPdbSourceLinkUrl(compilation, type));
Assert.True(compilationLink?.StartsWith("https://github.com/"));
Assert.True(compilationLink?.EndsWith("/blob/*/src/Docfx.Dotnet/DotnetApiCatalog.cs"));
Assert.True(compilationLink?.EndsWith(".cs"));

var method = type.GetMembers(nameof(DotnetApiCatalog.GenerateManagedReferenceYamlFiles)).FirstOrDefault();
Assert.NotNull(method);
var methodLink = ReplaceSHA(SymbolUrlResolver.GetPdbSourceLinkUrl(compilation, method));
Assert.True(compilationLink?.StartsWith("https://github.com/"));
Assert.True(compilationLink?.EndsWith("/blob/*/src/Docfx.Dotnet/DotnetApiCatalog.cs"));
Assert.True(compilationLink?.EndsWith(".cs"));

static string ReplaceSHA(string value)
{
Expand Down