Skip to content

perf: git.exe -> GitReader #9314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yufeih merged 3 commits into from
Oct 20, 2023
Merged

perf: git.exe -> GitReader #9314

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
aa758b7
perf: git.exe -> GitReader
yufeih Oct 20, 2023
c74d630
test(snapshot): update snapshots for bac1e4cbec8d9e0d98f5cc3fe684551c…
yufeih Oct 20, 2023
0e1f7da
no .git file
yufeih Oct 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
no .git file
  • Loading branch information
@yufeih
yufeih committed Oct 20, 2023
commit 0e1f7daee7640aa3782225b56800fd5bcc1a0807
5 changes: 3 additions & 2 deletions src/Docfx.Common/Git/GitUtility.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,8 +112,9 @@ static bool IsGitRoot(string directory)
{
var gitPath = Path.Combine(directory, ".git");

// git submodule contains only a .git file instead of a .git folder
return Directory.Exists(gitPath) || File.Exists(gitPath);
// GitReader does not support .git as file in submodules
// https://github.com/kekyo/GitReader/blob/4126738704ee8b6e330e99c6bc81e9de8bc925c9/GitReader.Core/Primitive/PrimitiveRepositoryFacade.cs#L27-L30
return Directory.Exists(gitPath);
}
}

Expand Down