Skip to content

fix: remove PDF missing TOC warning #9610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yufeih merged 1 commit into from
Jan 13, 2024
Merged

fix: remove PDF missing TOC warning #9610

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix: remove PDF missing TOC warning
  • Loading branch information
@yufeih
yufeih committed Jan 13, 2024
commit 8767fc231775e69807f53eef97c2bd55f65a84ae
6 changes: 2 additions & 4 deletions src/Docfx.App/PdfBuilder.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,19 +50,17 @@ public static Task Run(BuildJsonConfig config, string configDirectory, string? o
var outputFolder = Path.GetFullPath(Path.Combine(
string.IsNullOrEmpty(outputDirectory) ? Path.Combine(configDirectory, config.Output ?? "") : outputDirectory,
config.Dest ?? ""));

Logger.LogInfo($"Searching for manifest in {outputFolder}");
return CreatePdf(outputFolder);
}

public static async Task CreatePdf(string outputFolder)
{
var stopwatch = Stopwatch.StartNew();
Logger.LogInfo($"Searching for manifest in {outputFolder}");
var pdfTocs = GetPdfTocs().ToDictionary(p => p.url, p => p.toc);
if (pdfTocs.Count == 0)
{
Logger.LogWarning($"No PDF TOC's found in: {outputFolder}");
return;
}

Program.Main(new[] { "install", "chromium" });

Expand Down