Skip to content

Conversation

@filzrev
Copy link
Contributor

@filzrev filzrev commented Jan 23, 2024

This PR fixes the issue that it can't use "disableDefaultFilter": true' settings with custom filterConfig.yml'.

I've tested this PR manually with following configurations.

  "metadata": [
    {
      "filter": "filterConfig.yml",
      "disableDefaultFilter": true
    }
  ],

@codecov
Copy link

codecov bot commented Jan 23, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (ad6db16) 74.31% compared to head (e5a07ee) 74.31%.
Report is 2 commits behind head on main.

Files Patch % Lines
src/Docfx.Dotnet/SymbolFilter.cs 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9638   +/-   ##
=======================================
  Coverage   74.31%   74.31%           
=======================================
  Files         536      536           
  Lines       23173    23175    +2     
  Branches     4054     4054           
=======================================
+ Hits        17220    17222    +2     
  Misses       4851     4851           
  Partials     1102     1102           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@yufeih yufeih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @filzrev !

@yufeih yufeih merged commit 1a26bd4 into dotnet:main Jan 24, 2024
@yufeih yufeih added the bug-fix Makes the pull request to appear in "Bug Fixes" section of the next release note label Jan 24, 2024
@filzrev filzrev deleted the fix-loading-custom-filter branch April 1, 2024 05:03
p-kostov pushed a commit to ErpNetDocs/docfx that referenced this pull request Jun 28, 2024
…t loaded. (dotnet#9638)

fix: custom filter loading when default filter disabled
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug-fix Makes the pull request to appear in "Bug Fixes" section of the next release note

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants