fix: ApiPage is not generated when multiple namespaces defined across projects #9650
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #9650 +/- ##
==========================================
- Coverage 74.31% 74.31% -0.01%
==========================================
Files 536 536
Lines 23179 23181 +2
Branches 4054 4056 +2
==========================================
Hits 17226 17226
- Misses 4851 4853 +2
Partials 1102 1102 ☔ View full report in Codecov by Sentry. |
yufeih
added
the
bug-fix
yufeih
approved these changes
Jan 27, 2024
p-kostov
pushed a commit
to ErpNetDocs/docfx
that referenced
this pull request
Jun 28, 2024
… projects (dotnet#9650) fix: ApiPage is not generated when multiple namespaces exists
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is intended to fix #9618.
On current implementation.
CreateNamespaceTocmethod don't callyield return nodeifnode.containsLeafNodesisfalse.So if empty namespace is processed first. other items that share same namespaces are not included as docfx output.
This PR change logics to call
yield return nodewith following 2 condition.TocNodeis created & items are added.TocNodeis exists but has no items & items are added.