Skip to content

chore: Change JsonSchema EvaluationOptions instance to shared object #9807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yufeih merged 1 commit into from
Mar 21, 2024
Merged

chore: Change JsonSchema EvaluationOptions instance to shared object #9807

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions src/Docfx.Build.SchemaDriven/Validators/SchemaValidator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,12 @@ public class SchemaValidator
{
private readonly JsonSchema _schema;

private static readonly EvaluationOptions DefaultOptions = new EvaluationOptions
{
ValidateAgainstMetaSchema = false,
OutputFormat = OutputFormat.List,
};

static SchemaValidator()
{
SchemaRegistry.Global.Register(new("http://dotnet.github.io/docfx/schemas/v1.0/schema.json#"), MetaSchemas.Draft7);
Expand All @@ -25,11 +31,7 @@ public SchemaValidator(string json)
public void Validate(object obj)
{
var json = JsonSerializer.Serialize(obj);
var result = _schema.Evaluate(JsonDocument.Parse(json), new EvaluationOptions
{
ValidateAgainstMetaSchema = false,
OutputFormat = OutputFormat.List,
});
var result = _schema.Evaluate(JsonDocument.Parse(json), DefaultOptions);

if (result.IsValid)
return;
Expand Down