-
Notifications
You must be signed in to change notification settings - Fork 6.1k
Add doc for the latest "MacCatalyst is superset of iOS" updates #26032
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
gewarren
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might also be good to include a table showing the support combinations. I'll see if I can come up with one.
Co-authored-by: Genevieve Warren <[email protected]>
Thank you, i have updated the table bit and applied with all other suggestions |
jeffhandley
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left one comment where I wasn't sure if the spacing/indentation was correct. Beyond that, the only feedback I have is that we're using a few different terms:
- Related
- Superset
- Parent/Child
If we're going to use parent/child, then "related" is a good word that refers to the relationship between parent/child. But I don't know that parent/child is the most intuitive or helpful term for the concept; I think superset/subset is more informative of the direction of the relationship.
If we had superset/subset instead of parent/child, then I'm not sure that "related" is best, but I also can't think of a good replacement.
Right, also i noticed that we used |
|
I left some suggestions in a PR since that was easier than line by line suggestions. buyaa-n#2 |
Some rewording
Summary
Recently we updated the Platform Compatibility Analyzer to support a relationship of "MacCatalyst is a superset of IOS" using SupportedOSPlatformGuard attributes on the OperatingSystem method. We need to update the doc accordingly
Related PR: dotnet/roslyn-analyzers#5266