Skip to content

System.Drawing.Common config switch removal #35401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gewarren merged 3 commits into from
May 19, 2023
Merged

System.Drawing.Common config switch removal #35401

gewarren merged 3 commits into from
May 19, 2023

Conversation

@gewarren
Copy link
Contributor

@gewarren gewarren commented May 18, 2023 •
edited by github-actions bot
Loading

@dotnet-bot dotnet-bot added this to the May 2023 milestone May 18, 2023
@ghost ghost added the 🏁 Release: .NET 7 Work items for the .NET 7 release label May 18, 2023
@gewarren gewarren requested review from a team and ericstj May 18, 2023 17:29
BillWagner
BillWagner approved these changes May 19, 2023
View reviewed changes
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM @gewarren

You can :shipit: when ready.

@gewarren gewarren merged commit 3d18470 into dotnet:main May 19, 2023
@gewarren gewarren deleted the configswitch-drawing branch May 19, 2023 15:32
stephentoub
stephentoub reviewed May 19, 2023
View reviewed changes
docs/core/compatibility/core-libraries/7.0/system-drawing.md

## Recommended action

To use these APIs for cross-platform apps, migrate to one of the following libraries:
Copy link
Member

@stephentoub stephentoub May 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
To use these APIs for cross-platform apps, migrate to one of the following libraries:
To use these APIs for cross-platform apps, migrate to an alternative library, such as one of the following:

Copy link
Contributor Author

@gewarren gewarren May 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I've added that in #35414.

@gewarren gewarren mentioned this pull request May 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stephentoub stephentoub stephentoub left review comments

@ericstj ericstj ericstj left review comments

@BillWagner BillWagner BillWagner approved these changes

Assignees

No one assigned

Labels

🏁 Release: .NET 7 Work items for the .NET 7 release dotnet-fundamentals/svc

Projects

None yet

Milestone

May 2023

5 participants

@gewarren @BillWagner @stephentoub @ericstj @dotnet-bot