Skip to content

Conversation

hbazerbashi
Copy link
Contributor

Some links weren't working because they had two "https://".

Thanks,
Hasan.

Some links weren't working because they had two "https://". This is my first edit on Gitbub and I'm not sure if it is ok to edit the file here, so, sorry if that's not ok.

Thanks,
Hasan.
@JRAlexander JRAlexander added the ✨ 1st-time docs contributor! Indicates PRs from new contributors to the docs repository label Jan 5, 2018
Copy link
Contributor

@JRAlexander JRAlexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for your contribution, @hbazerbashi! Very nice catch! I'll merge as soon I verify that it built correctly.

@hbazerbashi
Copy link
Contributor Author

Thanks for the quick response and for the encouragement 😊 👍

I also edited the link to "Walkthrough 2". It was pointing to a "TBD" link. Sorry I didn't get it the first time.

@JRAlexander
Copy link
Contributor

No problem. I'll re-review and then verify. Thanks again for the help!!!

@mairaw mairaw merged commit d10dcdf into dotnet:master Jan 5, 2018
@hbazerbashi hbazerbashi deleted the patch-1 branch January 5, 2018 20:32
@hbazerbashi
Copy link
Contributor Author

Hi, I'm just curious, when does the update show on the documentation page?

@mairaw
Copy link
Contributor

mairaw commented Jan 5, 2018

It should be live later today @hbazerbashi. We usually do a push to production once a day.

@hbazerbashi
Copy link
Contributor Author

Thanks for the quick reply. This was a great experience, contributing the first time 😊

@mairaw
Copy link
Contributor

mairaw commented Jan 5, 2018

Yay! We really strive for that and I hope we see more contributions from you in the future.

@JRAlexander
Copy link
Contributor

That's wonderful to hear!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

✨ 1st-time docs contributor! Indicates PRs from new contributors to the docs repository

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants