Added github label rules from other repo #1134
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mairaw
requested changes
Nov 20, 2018
.ghal.rules.json
Outdated
| "defaults": [ ":watch: Not Triaged" ], | ||
| "product": { | ||
| "(?i).*": "Source - Docs.ms", | ||
| "(?i)dotnet-csharp$": ":books: Area - C# Guide", |
There was a problem hiding this comment.
I think only the first one should be kept (Source - Docs.ms) - all the others don't make sense here
| "(?i).*master\/docs\/standard\/modernize-with-azure-and-containers.*": ":card_file_box: Technology - .NET Architecture,:book: e-book - Modernizing w/ Windows containers", | ||
| "(?i).*master\/docs\/standard\/security.*": ":card_file_box: Technology - Security", | ||
| "(?i).*master\/docs\/standard\/serverless-architecture.*": ":card_file_box: Technology - .NET Architecture,:book: e-book - Serverless apps", | ||
| "(?i).*dotnet-api-docs\/blob\/master\/xml\/system\\.net.*": ":card_file_box: Technology - NCL", |
There was a problem hiding this comment.
keep just these for dotnet-api-docs, remove the rest
mairaw
approved these changes
Nov 20, 2018
|
@mairaw can i just merge? or do i need to wait for build (which doesn't really apply here) |
|
We tend to wait even when it doesn't apply. Up to you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Label rules for dotnet/docs#9128