Skip to content

Conversation

@lythix
Copy link
Contributor

@lythix lythix commented Feb 6, 2019

Summary

Describe your changes here.

Copied link in another page to the Windows Sockets version 2 API error codes and put it on this page that also references it without a link.

Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the link @lythix. The change looks great but we should also remove the reference to MSDN library. Please see my suggestion.

@mairaw mairaw added the ✨ 1st-time dotnet-api-docs contributor! Indicates PRs from new contributors to the dotnet-api-docs repository label Feb 6, 2019
@mairaw mairaw added this to the February 2019 milestone Feb 6, 2019
@lythix lythix requested a review from karelz as a code owner February 7, 2019 05:52
@mairaw mairaw removed the request for review from karelz February 7, 2019 08:04
Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for applying the suggested change @lythix. I'll merge your PR now and your changes should be live within a day or so.

@mairaw mairaw merged commit 8343f0d into dotnet:master Feb 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

✨ 1st-time dotnet-api-docs contributor! Indicates PRs from new contributors to the dotnet-api-docs repository

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants