Skip to content

Port System.Text.Json source comments to Docs #2360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 8 commits into from
Closed

Port System.Text.Json source comments to Docs #2360

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
f7e0281
Port System.Text.Json source comments to Docs
carlossanlop Apr 24, 2019
278fb4e
Apply suggestions from code review
carlossanlop Apr 25, 2019
de476f8
Adding missing remarks and some more exceptions.
carlossanlop Apr 25, 2019
a3f5ee4
Adding missing remarks and some more exceptions.
carlossanlop Apr 25, 2019
2d2075f
Update JsonElement.xml
carlossanlop Apr 25, 2019
5517bd6
Update Utf8JsonWriter.xml
carlossanlop Apr 26, 2019
12b1158
Apply suggestions from code review
May 7, 2019
1068a9b
Apply suggestions from code review
carlossanlop May 7, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update Utf8JsonWriter.xml 
Removed remark that is not ready to be published.
  • Loading branch information
@carlossanlop
carlossanlop authored Apr 26, 2019
commit 5517bd6e0637096b982a2fa958cd138ff5d1a722
5 changes: 2 additions & 3 deletions xml/System.Text.Json/Utf8JsonWriter.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,8 +82,7 @@ This is the reason why the constructor accepts a <xref:System.Text.Json.JsonWrit
<summary>Gets the total number of bytes committed to the output by the <see cref="T:System.Text.Json.Utf8JsonWriter" /> so far for the current instance of the <see cref="T:System.Text.Json.Utf8JsonWriter" />.
This indicates how much the <see cref="T:System.Buffers.IBufferWriter`1" /> has advanced.</summary>
<value>The total number of bytes committed to the output by the <see cref="T:System.Text.Json.Utf8JsonWriter" /> so far.</value>
<remarks>In the case of IBufferwriter, this is how much the IBufferWriter has advanced.
In the case of Stream, this is how much data has been written to the stream.</remarks>
<remarks>To be added.</remarks>
</Docs>
</Member>
<Member MemberName="BytesWritten">
Expand Down Expand Up @@ -2280,4 +2279,4 @@ The JSON data to be written would be invalid JSON (while validation is enabled).
</Docs>
</Member>
</Members>
</Type>
</Type>