Skip to content

Update ValidationContext.MemberName Property to reflect a recent change #3470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Nov 23, 2019
Merged

Update ValidationContext.MemberName Property to reflect a recent change #3470

merged 8 commits into from
Nov 23, 2019

Conversation

@HongGit
Copy link
Contributor

@HongGit HongGit commented Nov 12, 2019

Summary

There was a fix released in October, which has a fix for ValidationContext.MemberName Property. Update the Doc to reflect this change.

@HongGit HongGit changed the title Hongli/work ValidationContext.MemberName Property to relect a recent change Nov 12, 2019
@HongGit HongGit changed the title ValidationContext.MemberName Property to relect a recent change ValidationContext.MemberName Property to reflect a recent change Nov 12, 2019
@HongGit HongGit changed the title ValidationContext.MemberName Property to reflect a recent change Update ValidationContext.MemberName Property to reflect a recent change Nov 12, 2019
mairaw
mairaw requested changes Nov 12, 2019
View reviewed changes
Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @HongGit. Left some comments for you to consider.

@mairaw mairaw added this to the November 2019 milestone Nov 12, 2019
@HongGit HongGit requested a review from mairaw November 12, 2019 18:56
@HongGit
Copy link
Contributor Author

HongGit commented Nov 12, 2019

@mairaw PR has been updated, can you please review?

mairaw
mairaw approved these changes Nov 23, 2019
View reviewed changes
Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving so you're unblocked from merging but I've left some additional suggestions that I think help clarify (at least for me) the default values too and the changes.

@mairaw mairaw merged commit 0acf7c4 into master Nov 23, 2019
@mairaw mairaw deleted the hongli/work branch November 23, 2019 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mairaw mairaw mairaw approved these changes

Assignees

@HongGit HongGit

Labels

None yet

Projects

None yet

Milestone

November 2019

Development

Successfully merging this pull request may close these issues.

3 participants

@HongGit @mairaw