Skip to content

Missing API docs part 1 - SA #3531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 22, 2019
Merged

Missing API docs part 1 - SA #3531

merged 4 commits into from
Nov 22, 2019

Conversation

@steveada
Copy link
Contributor

@steveada steveada commented Nov 19, 2019

Totals 51 rows over 12 files

@dnfclas
Copy link

dnfclas commented Nov 19, 2019 •
edited
Loading

CLA assistant check
All CLA requirements met.

@steveada
Copy link
Contributor Author

steveada commented Nov 19, 2019

@mairaw Including you on review

@mairaw mairaw added the vendor-project Indicates the issue/pr is related to a vendor project. label Nov 19, 2019
@mairaw mairaw requested review from mairaw and removed request for KathleenDollard November 19, 2019 20:14
@mairaw mairaw added this to the November 2019 milestone Nov 19, 2019
@mairaw mairaw closed this Nov 19, 2019
@mairaw mairaw reopened this Nov 19, 2019
@mairaw
Copy link
Contributor

mairaw commented Nov 19, 2019

Build failed with a weird error message. Trying to build again.

@steveada
Copy link
Contributor Author

steveada commented Nov 19, 2019

@mairaw Yes, I have some unescaped characters in one of the files; fixing them now

mairaw
mairaw requested changes Nov 20, 2019
View reviewed changes
Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @steveada! I've left a few comments. The old IntelliSense files I sent you should be helpful to recover the previous existing descriptions where I commented.

xml/Microsoft.CSharp.Activities/CSharpReference`1.xml Outdated
</Attributes>
<Docs>
<typeparam name="TResult">To be added.</typeparam>
<typeparam name="TResult">The type of the return value of the C# reference.</typeparam>
Copy link
Contributor

@mairaw mairaw Nov 20, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BillWagner do you think we could just say this?

Suggested change
<typeparam name="TResult">The type of the return value of the C# reference.</typeparam>
<typeparam name="TResult">The type of the C# reference.</typeparam>

@mairaw mairaw added the new-content Indicates PRs that contain new articles label Nov 21, 2019
mairaw
mairaw approved these changes Nov 22, 2019
View reviewed changes
Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thank you @steveada!

@mairaw mairaw merged commit a133853 into dotnet:master Nov 22, 2019
@steveada steveada deleted the missing_api_docs_1 branch November 22, 2019 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mairaw mairaw mairaw approved these changes

Assignees

@steveada steveada

Labels

new-content Indicates PRs that contain new articles vendor-project Indicates the issue/pr is related to a vendor project.

Projects

None yet

Milestone

November 2019

Development

Successfully merging this pull request may close these issues.

3 participants

@steveada @dnfclas @mairaw