Adds docs for Microsoft.Extensions.Primitives #4105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xml/Microsoft.Extensions.Primitives/CancellationChangeToken.xml
Outdated
Show resolved
Hide resolved
carlossanlop
suggested changes
Apr 14, 2020
Contributor
carlossanlop
left a comment
carlossanlop
left a comment
There was a problem hiding this comment.
Thanks @maryamariyan for porting these. I left some comments for you to consider. Please make sure to fill the few elements that were not ported and still contain "To be added" (excluding remarks, those are optional).
maryamariyan
force-pushed
the
ms-primitives
branch
from
03c17ec to
36dbc33
Compare
maryamariyan
commented
Apr 16, 2020
xml/Microsoft.Extensions.Primitives/CancellationChangeToken.xml
Outdated
Show resolved
Hide resolved
maryamariyan
commented
Apr 16, 2020
xml/Microsoft.Extensions.Primitives/CancellationChangeToken.xml
Outdated
Show resolved
Hide resolved
maryamariyan
commented
Apr 16, 2020
maryamariyan
commented
Apr 16, 2020
maryamariyan
commented
Apr 16, 2020
maryamariyan
commented
Apr 16, 2020
maryamariyan
commented
Apr 16, 2020
correct value sentences for boolean types
Contributor
Author
|
@carlossanlop applied the changes. ready for review |
xml/Microsoft.Extensions.Primitives/CancellationChangeToken.xml
Outdated
Show resolved
Hide resolved
Co-Authored-By: Carlos Sanchez Lopez <[email protected]>
Co-Authored-By: Carlos Sanchez Lopez <[email protected]>
Co-Authored-By: Carlos Sanchez Lopez <[email protected]>
Co-Authored-By: Carlos Sanchez Lopez <[email protected]>
carlossanlop
suggested changes
Apr 24, 2020
Contributor
carlossanlop
left a comment
carlossanlop
left a comment
There was a problem hiding this comment.
One more suggestion, @maryamariyan . Can you please take a look?
Co-Authored-By: Carlos Sanchez Lopez <[email protected]>
carlossanlop
approved these changes
May 13, 2020
Contributor
carlossanlop
left a comment
carlossanlop
left a comment
There was a problem hiding this comment.
LGTM. I'll merge this.
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Microsoft.Extensions.Primitives docs.