Fix SpecialFiles.ProgramFiles docs to match the actual implementation. #4187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* ProgramFiles return x86 folder when it's run on a x86 process, regardless of the system architecture
jkotas
reviewed
May 1, 2020
jkotas
reviewed
May 1, 2020
jkotas
approved these changes
May 1, 2020
Co-authored-by: Jan Kotas <[email protected]>
sos-dll
approved these changes
May 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
ProgramFiles return x86 folder when it's run on a x86 process, regardless of the system architecture. This PR fixes the occurrences of "non-x86 system" to "non-x86 process".
Fixes dotnet/runtime#35705
cc @jkotas @sos-dll