Skip to content

Conversation

@BillWagner
Copy link
Member

No description provided.

<AttributeName>System.Runtime.InteropServices.TypeLibType(2)</AttributeName>
</Attribute>
<Attribute FrameworkAlternate="netframework-4.0;netframework-4.5;netframework-4.5.1;netframework-4.5.2;netframework-4.6;netframework-4.6.1;netframework-4.6.2;netframework-4.7;netframework-4.7.1;netframework-4.7.2;netframework-4.8;netcore-3.0;netcore-3.1;net-5.0">
<Attribute FrameworkAlternate="netframework-4.0;netframework-4.5;netframework-4.5.1;netframework-4.5.2;netframework-4.6;netframework-4.6.1;netframework-4.6.2;netframework-4.7;netframework-4.7.1;netframework-4.7.2;netframework-4.8;netcore-3.0;netcore-3.1;net-5.0;dotnet-plat-ext-5.0">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mairaw Should there be net-5.0 and dotnet-plat-ext-5.0?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, that concept still exists. .net-5.0 represents the shared framework.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now if it's correct for this API to exist in both I'm not sure

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And the API Catalog doesn't seem to have .NET 5.0 info yet
https://apisof.net/catalog/Accessibility.CAccPropServicesClass

/cc @safern @terrajobst

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, working on that as well. https://github.com/dotnet/api-catalog-infra

Should have it next week.

@BillWagner
Copy link
Member Author

This is generally good, I'm going to :shipit:, and then open a second PR that addresses some of the warnings that we should filter out.

@BillWagner BillWagner merged commit 5a1a453 into master May 12, 2020
@BillWagner BillWagner deleted the smoke-test branch May 12, 2020 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants