Skip to content

Conversation

@dotnet-bot dotnet-bot added this to the May 2020 milestone May 26, 2020
@v-mepa
Copy link
Contributor Author

v-mepa commented May 26, 2020

FYI @mairaw
Was little confused about the last API, hope I have updated the correct samples :), let me know.

@mairaw mairaw self-requested a review May 26, 2020 19:48
@mairaw mairaw added the 👩‍💻 .NET Interactive These issues relate to using .NET Interactive in docs label May 26, 2020
Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good but left a couple of comments. For the last one, Excel probably auto-filled my comment. It was supposed to say Only example 2. My bad!

[!code-csharp[System.Double.MinValue#1](~/samples/snippets/csharp/VS_Snippets_CLR_System/system.double.minvalue/cs/minvalueex.cs#1)]
:::code language="csharp" source="~/samples/snippets/csharp/VS_Snippets_CLR_System/system.double.minvalue/cs/minvalueex.cs" interactive="try-dotnet" id="Snippet1":::
[!code-vb[System.Double.MinValue#1](~/samples/snippets/visualbasic/VS_Snippets_CLR_System/system.double.minvalue/vb/minvalueex.vb#1)]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's change the syntax for vb too

## Examples
The following code example illustrates the use of <xref:System.Double.MinValue?displayProperty=nameWithType>:
[!code-cpp[Double Example#2](~/samples/snippets/cpp/VS_Snippets_CLR/Double Example/CPP/source.cpp#2)]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's change the syntax for the other languages here too

@v-mepa
Copy link
Contributor Author

v-mepa commented May 28, 2020

@mairaw I am seeing 2 commits for "update_syntax_for_other_languages" , Git asked me to pull before committing and I did and now its showing 2 commits. Should I remove
82cc68a commit. Please advise.

@mairaw
Copy link
Contributor

mairaw commented May 29, 2020

Let me see if I can comment on the problems introduced instead of you having to remove the commits. Because you applied my suggestions here first, you first need to do a git pull to bring the changes into your local version first.

@v-mepa
Copy link
Contributor Author

v-mepa commented May 29, 2020

Okay make sense now, I will keep that in mind from now on. Learning new things each day and I am loving it Maira :)

Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions to address the issues introduced

Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more fixes needed

@mairaw mairaw mentioned this pull request Jun 1, 2020
v-mepa and others added 10 commits June 2, 2020 11:49
Co-authored-by: Maira Wenzel <[email protected]>
Co-authored-by: Maira Wenzel <[email protected]>
Co-authored-by: Maira Wenzel <[email protected]>
Co-authored-by: Maira Wenzel <[email protected]>
Co-authored-by: Maira Wenzel <[email protected]>
Co-authored-by: Maira Wenzel <[email protected]>
Co-authored-by: Maira Wenzel <[email protected]>
Co-authored-by: Maira Wenzel <[email protected]>
Co-authored-by: Maira Wenzel <[email protected]>
Co-authored-by: Maira Wenzel <[email protected]>
Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything working now! Thanks!

@mairaw mairaw merged commit f5b2862 into dotnet:master Jun 15, 2020
@v-mepa v-mepa deleted the add_try_dotnet_to_batch_9 branch June 15, 2020 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

👩‍💻 .NET Interactive These issues relate to using .NET Interactive in docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants