-
Notifications
You must be signed in to change notification settings - Fork 1.6k
.NET Interactive: Enable_try_dotnet_to_batch_9 #4283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
FYI @mairaw |
mairaw
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good but left a couple of comments. For the last one, Excel probably auto-filled my comment. It was supposed to say Only example 2. My bad!
xml/System/Double.xml
Outdated
| [!code-csharp[System.Double.MinValue#1](~/samples/snippets/csharp/VS_Snippets_CLR_System/system.double.minvalue/cs/minvalueex.cs#1)] | ||
| :::code language="csharp" source="~/samples/snippets/csharp/VS_Snippets_CLR_System/system.double.minvalue/cs/minvalueex.cs" interactive="try-dotnet" id="Snippet1"::: | ||
| [!code-vb[System.Double.MinValue#1](~/samples/snippets/visualbasic/VS_Snippets_CLR_System/system.double.minvalue/vb/minvalueex.vb#1)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's change the syntax for vb too
xml/System/Double.xml
Outdated
| ## Examples | ||
| The following code example illustrates the use of <xref:System.Double.MinValue?displayProperty=nameWithType>: | ||
| [!code-cpp[Double Example#2](~/samples/snippets/cpp/VS_Snippets_CLR/Double Example/CPP/source.cpp#2)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's change the syntax for the other languages here too
Co-authored-by: Maira Wenzel <[email protected]>
Co-authored-by: Maira Wenzel <[email protected]>
Co-authored-by: Maira Wenzel <[email protected]>
|
Let me see if I can comment on the problems introduced instead of you having to remove the commits. Because you applied my suggestions here first, you first need to do a git pull to bring the changes into your local version first. |
|
Okay make sense now, I will keep that in mind from now on. Learning new things each day and I am loving it Maira :) |
mairaw
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggestions to address the issues introduced
mairaw
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few more fixes needed
Co-authored-by: Maira Wenzel <[email protected]>
Co-authored-by: Maira Wenzel <[email protected]>
Co-authored-by: Maira Wenzel <[email protected]>
Co-authored-by: Maira Wenzel <[email protected]>
Co-authored-by: Maira Wenzel <[email protected]>
Co-authored-by: Maira Wenzel <[email protected]>
Co-authored-by: Maira Wenzel <[email protected]>
Co-authored-by: Maira Wenzel <[email protected]>
Co-authored-by: Maira Wenzel <[email protected]>
Co-authored-by: Maira Wenzel <[email protected]>
Co-authored-by: Maira Wenzel <[email protected]>
mairaw
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything working now! Thanks!
Enable_try_dotnet_to_batch_9