Skip to content

Conversation

@v-mepa
Copy link
Contributor

@v-mepa v-mepa commented Jun 10, 2020

Enable_try_dotnet_to_batch_11a

S No. URL Batch Comments
1 https://docs.microsoft.com/en-us/dotnet/api/system.array.sort Batch 11  
2 https://docs.microsoft.com/en-us/dotnet/api/system.invalidoperationexception Batch 11 Only examples 7, 8, 10, 11, 13, 15, 17, 19. Review output for 10
3 https://docs.microsoft.com/en-us/dotnet/api/system.array.copy Batch 11 Duplicate samples for all overloads? Potentially move it to the MemberGroup
4 https://docs.microsoft.com/en-us/dotnet/api/system.argumentexception Batch 11  
5 https://docs.microsoft.com/en-us/dotnet/api/system.formatexception Batch 11 Only examples 4, 8, 12. Others throw exception or are culture dependent.
6 https://docs.microsoft.com/en-us/dotnet/api/system.convert Batch 11 Only example 2. First example uses Console.ReadLine

@dotnet-bot dotnet-bot added this to the June 2020 milestone Jun 10, 2020
@v-mepa
Copy link
Contributor Author

v-mepa commented Jun 10, 2020

fyi @mairaw

@mairaw mairaw added the 👩‍💻 .NET Interactive These issues relate to using .NET Interactive in docs label Jun 15, 2020
@mairaw mairaw self-requested a review June 15, 2020 02:40
Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @v-mepa. Changes look good. Left a few comments to be addressed before we can merge.

@mairaw mairaw mentioned this pull request Jun 18, 2020
@mairaw mairaw closed this Jun 29, 2020
@mairaw mairaw reopened this Jun 29, 2020
@mairaw
Copy link
Contributor

mairaw commented Jun 30, 2020

@v-mepa I see that you applied my suggestions here but I couldn't apply the suggestions for the parts that weren't touched. Can you review my comments and add the interactive to the samples missing too? Thanks!

@v-mepa
Copy link
Contributor Author

v-mepa commented Jul 2, 2020

Enabled interactive in all previous samples as per your comment which are 13,15,17 & 19 now and are enabled. Let me know :)

2 https://docs.microsoft.com/en-us/dotnet/api/system.invalidoperationexception Batch 11 Only examples 7, 8, 10, 11, 13, 15, 17, 19. Review output for 10

image

Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect. Thanks!

@mairaw mairaw merged commit efdbc35 into dotnet:master Jul 2, 2020
@v-mepa v-mepa deleted the add_try_dotnet_to_batch_11a branch July 6, 2020 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

👩‍💻 .NET Interactive These issues relate to using .NET Interactive in docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants