-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Add DispatcherTimer to the list of available timer classes #4371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This is just meant to be a hint. Why is there's no feedback section at the bottom? Feel free to close this and do it in a better way.
gewarren
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this. The feedback section was removed from the API ref docs simply because we could not answer every issue in a timely fashion.
Co-authored-by: Genevieve Warren <[email protected]>
Co-authored-by: Genevieve Warren <[email protected]>
softworkz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All changes are fine for me!
That's unfortunate, I really liked it. Often just for reading the comments from other users.. I understand that there's a small edge for this getting misused as a support channel, but still - most of the questions I read - were still justified to be covered by the documentation to avoid those coming up as support questions.. |
|
@kouvel Do you approve this PR? |
|
Makes sense to me but I don't have much background or context in that area. @stephentoub, who would know more about this? |
|
I see that Windows Forms' counterpart is included already, so it seems fine to list WPF's as well. |
|
It was just that I had momentarily forgotten the name of But if I had known that it would allocate so many people's time, I wouldn't have submitted. Apologies.. |
|
There is a similar list of timer classes at System.Timers.Timer. It would be good to keep these synchronized: dotnet-api-docs/xml/System.Timers/Timer.xml Lines 85 to 91 in 50c98f5
That list seems to be out of date already, as System.Windows.Forms.Timer is available on .NET Core 3.0 and later. I suppose the "this topic" self-reference prevents !INCLUDE from being used. |
|
@KalleOlaviNiemitalo Good point. Would you like to create a new PR for System.Timers.Timer? |
|
No, I wouldn't. |
This is just meant to be a hint.
Why is there's no feedback section at the bottom?
Feel free to close this and do it in a better way.