The 3rd batch patch for msdn url #4381
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@mairaw @BillWagner @TianqiZhang This is the 2nd Patch, please help to review it. |
mairaw
requested changes
Jun 18, 2020
Contributor
mairaw
left a comment
mairaw
left a comment
There was a problem hiding this comment.
I'm 2/3 done. I'll finish the rest of the review later.
xml/System.ServiceModel.Configuration/AuthorizationPolicyTypeElementCollection.xml
Outdated
Show resolved
Hide resolved
xml/System.ServiceModel.Configuration/BaseAddressElementCollection.xml
Outdated
Show resolved
Hide resolved
xml/System.ServiceModel.Configuration/BasicHttpBindingCollectionElement.xml
Outdated
Show resolved
Hide resolved
xml/System.ServiceModel.Configuration/BasicHttpBindingElement.xml
Outdated
Show resolved
Hide resolved
mairaw
reviewed
Jun 18, 2020
Contributor
mairaw
left a comment
mairaw
left a comment
There was a problem hiding this comment.
Review is done... I just have a few additional comments.
Co-authored-by: Maira Wenzel <[email protected]>
mairaw
reviewed
Jun 24, 2020
Contributor
mairaw
left a comment
mairaw
left a comment
There was a problem hiding this comment.
Found one more fix to be made.
Co-authored-by: Maira Wenzel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Describe your changes here.
Fixes #Issue_Number (if available)