Skip to content

Conversation

carlossanlop
Copy link
Contributor

Area owners of Microsoft.Extensions.Diagnostic*: @maryamariyan @ericstj
Note: The area owners page does not specify the label area-Extensions-DiagnosticAdapter.

@opbld30
Copy link

opbld30 commented Oct 1, 2020

Docs Build status updates of commit 712a061:

⚠️ Validation status: warnings

File Status Preview URL Details
xml/Microsoft.Extensions.DependencyInjection/PollyServiceCollectionExtensions.xml ⚠️Warning View Details
xml/Microsoft.Extensions.DiagnosticAdapter.Internal/ProxyBase.xml ✅Succeeded
xml/Microsoft.Extensions.DiagnosticAdapter.Internal/ProxyEnumerable`2+ProxyEnumerator.xml ✅Succeeded
xml/Microsoft.Extensions.DiagnosticAdapter.Internal/ProxyEnumerable`2.xml ✅Succeeded
xml/Microsoft.Extensions.DiagnosticAdapter.Internal/ProxyFactory.xml ✅Succeeded
xml/Microsoft.Extensions.DiagnosticAdapter.Internal/ProxyList`2.xml ✅Succeeded
xml/Microsoft.Extensions.DiagnosticAdapter/DiagnosticSourceAdapter.xml ✅Succeeded View

xml/Microsoft.Extensions.DependencyInjection/PollyServiceCollectionExtensions.xml

  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Polly.Registry.PolicyRegistry'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Polly.Registry.IPolicyRegistry`1'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Polly.Registry.IReadOnlyPolicyRegistry`1'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Polly.Registry.IPolicyRegistry`1'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Polly.Registry.IPolicyRegistry`1'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Polly.Registry.IReadOnlyPolicyRegistry`1'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Polly.Registry.IPolicyRegistry`1'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Polly.Registry.PolicyRegistry'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Polly.Registry.IPolicyRegistry`1'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Polly.Registry.IPolicyRegistry`1'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Polly.Registry.IPolicyRegistry`1'.

For more details, please refer to the build report.

If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@ericstj ericstj requested review from Pilchie and JunTaoLuo and removed request for maryamariyan and ericstj October 1, 2020 17:02
@ericstj
Copy link
Member

ericstj commented Oct 1, 2020

Actually this is owned by @Pilchie's team and is no longer part of net5.0. The source code resides in https://github.com/dotnet/extensions/tree/release/3.1/src/DiagnosticAdapter

@ericstj
Copy link
Member

ericstj commented Oct 1, 2020

Correction here. Title is actually wrong. The only problem reported is from Microsoft.Extensions.Http.Polly. This appears to be a complete duplicate of #4932.

@ericstj ericstj closed this Oct 1, 2020
@ericstj ericstj reopened this Oct 1, 2020
@ericstj
Copy link
Member

ericstj commented Oct 1, 2020

Apologies, I misunderstood here. I see this is adding docs and I shouldn't be focused on the validation status

@opbld32
Copy link

opbld32 commented Oct 1, 2020

Docs Build status updates of commit 712a061:

⚠️ Validation status: warnings

File Status Preview URL Details
xml/Microsoft.Extensions.DependencyInjection/PollyServiceCollectionExtensions.xml ⚠️Warning View Details
xml/Microsoft.Extensions.DiagnosticAdapter.Internal/ProxyBase.xml ✅Succeeded
xml/Microsoft.Extensions.DiagnosticAdapter.Internal/ProxyEnumerable`2+ProxyEnumerator.xml ✅Succeeded
xml/Microsoft.Extensions.DiagnosticAdapter.Internal/ProxyEnumerable`2.xml ✅Succeeded
xml/Microsoft.Extensions.DiagnosticAdapter.Internal/ProxyFactory.xml ✅Succeeded
xml/Microsoft.Extensions.DiagnosticAdapter.Internal/ProxyList`2.xml ✅Succeeded
xml/Microsoft.Extensions.DiagnosticAdapter/DiagnosticSourceAdapter.xml ✅Succeeded View

xml/Microsoft.Extensions.DependencyInjection/PollyServiceCollectionExtensions.xml

  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Polly.Registry.IPolicyRegistry`1'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Polly.Registry.PolicyRegistry'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Polly.Registry.PolicyRegistry'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Polly.Registry.IPolicyRegistry`1'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Polly.Registry.IReadOnlyPolicyRegistry`1'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Polly.Registry.IPolicyRegistry`1'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Polly.Registry.IPolicyRegistry`1'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Polly.Registry.IPolicyRegistry`1'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Polly.Registry.IPolicyRegistry`1'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Polly.Registry.IPolicyRegistry`1'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Polly.Registry.IReadOnlyPolicyRegistry`1'.

For more details, please refer to the build report.

If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@ericstj
Copy link
Member

ericstj commented Oct 1, 2020

So as I mentioned above we didn't even touch this assembly in .NET 5.0, it only builds in 3.1. There was no change to this component's docs, but some interfaces that it implements got better docs which is what seems to have caused this change.

Copy link
Member

@ericstj ericstj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks to just be copying interface docs to undocumented members that implement that interface.

@carlossanlop carlossanlop merged commit b83e6e0 into dotnet:master Oct 14, 2020
@carlossanlop carlossanlop deleted the M_E_Diagnostic branch October 14, 2020 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants