Skip to content

Conversation

gewarren
Copy link
Contributor

@gewarren gewarren commented Oct 6, 2020

Contributes to dotnet/docs#20815.

Preview link.

@opbld30
Copy link

opbld30 commented Oct 6, 2020

Docs Build status updates of commit 4db38a3:

🕙 Pending: waiting for processors (11 builds ahead of you)

⚠️ Docs Build is busy, currently there are 11 builds ahead of this one, for more information you can view the Build queue graph on the Docs Portal.

@opbld30

This comment has been minimized.

@opbld30
Copy link

opbld30 commented Oct 6, 2020

Docs Build status updates of commit 3188ab9:

🕙 Pending: waiting for processors (10 builds ahead of you)

⚠️ Docs Build is busy, currently there are 10 builds ahead of this one, for more information you can view the Build queue graph on the Docs Portal.

@opbld30
Copy link

opbld30 commented Oct 6, 2020

Docs Build status updates of commit 3188ab9:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Text.Json/JsonSerializer.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@opbld32

This comment has been minimized.

@opbld32

This comment has been minimized.

@opbld32
Copy link

opbld32 commented Oct 7, 2020

Docs Build status updates of commit 3efff67:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Text.Json/JsonSerializer.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@opbld31
Copy link

opbld31 commented Oct 7, 2020

Docs Build status updates of commit 8a0618c:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Text.Json/JsonSerializer.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@gewarren gewarren requested review from ahsonkhan and buyaa-n October 7, 2020 15:48
@opbld31
Copy link

opbld31 commented Oct 7, 2020

Docs Build status updates of commit 8a218dd:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Text.Json/JsonSerializer.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

Copy link
Contributor

@buyaa-n buyaa-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@gewarren gewarren merged commit 7dfda99 into dotnet:master Oct 7, 2020
@gewarren gewarren deleted the deserialize branch October 7, 2020 22:29

-or-

.NET Core 3.1 and later versions only: <typeparamref name="TValue" /> is <see cref="T:System.Char" /> and <paramref name="json" /> is a null reference (<code>JsonSerializer.Deserialize&lt;char&gt;("null");</code>) or an empty string.</exception>
Copy link
Contributor

@ahsonkhan ahsonkhan Oct 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is unnecessary info to the user, and isn't totally accurate. Please revert this part of the change and remove this sentence.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants