-
Notifications
You must be signed in to change notification settings - Fork 1.6k
.NET 5.0 RC2 API updates #4978
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.NET 5.0 RC2 API updates #4978
Conversation
Build.Reason:Manual by Genevieve Warren Build.Url:https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=164203&view=results source_repo.branch:net5-rc2 source_repo.url:https://apidrop.visualstudio.com/_git/binaries
* Automatic port of System.OperatingSystem docs for RC2 (#4852) Co-authored-by: carlossanlop <[email protected]> * Add Missing System.Diagnostics docs (#4856) * Add Missing System.Diagnostics docs * Apply suggestions from code review Co-authored-by: Carlos Sanchez <[email protected]> Co-authored-by: Carlos Sanchez <[email protected]> * Automatically port System.Diagnostics docs for RC2 (#4853) * Automatically port System.Diagnostics docs for RC2 * Update xml/System.Diagnostics/ActivitySamplingResult.xml Co-authored-by: Carlos Sanchez <[email protected]> * Update xml/System.Diagnostics/Process.xml Co-authored-by: carlossanlop <[email protected]> Co-authored-by: Tarek Mahmoud Sayed <[email protected]> * Automatic port of RegexParse* documentation (#4850) * Automatic port of RegexParse* documentation * Update xml/System.Text.RegularExpressions/RegexParseError.xml * Apply suggestions from code review * Update RegexParseException * Update xml/System.Text.RegularExpressions/RegexParseException.xml * Update xml/System.Text.RegularExpressions/RegexParseException.xml Co-authored-by: carlossanlop <[email protected]> Co-authored-by: Prashanth Govindarajan <[email protected]> * Add ssl API added between preview 7 and 8 (#4860) * Automatic port of Reflection RC2 documentation (#4851) * Revert "Add ssl API added between preview 7 and 8 (#4860)" (#4868) This reverts commit 10d2b88. * Add ssl API added between preview 7 and 8 #2 (#4869) * Add ssl API added between preview 7 and 8 * Apply suggestions from code review Co-authored-by: Genevieve Warren <[email protected]> * Update xml/System.Net.Security/SslStream.xml * Apply @wfurt comments * Add missing remark headers * Apply suggestions from code review Co-authored-by: Genevieve Warren <[email protected]> Co-authored-by: Jan Jahoda <[email protected]> Co-authored-by: Genevieve Warren <[email protected]> * Documentation for System.Net.Http.SocketsHttpHandler.ConnectCallback (#4861) * Documentation for System.Net.Http.SocketsHttpHandler.ConnectCallback * Apply PR comments * Apply suggestions from code review Co-authored-by: Genevieve Warren <[email protected]> Co-authored-by: Jan Jahoda <[email protected]> Co-authored-by: Genevieve Warren <[email protected]> * Add a remark to AddEvent method (#4871) * Add a remark to AddEvent method * Apply suggestions from code review Co-authored-by: Genevieve Warren <[email protected]> Co-authored-by: Genevieve Warren <[email protected]> * Automatic port of CryptoStream docs (#4888) Co-authored-by: carlossanlop <[email protected]> * Automatic port of System.Buffers docs (#4882) Co-authored-by: carlossanlop <[email protected]> * resolve isprefix conflict * Automatic port of System.Data.Common docs (#4885) Co-authored-by: carlossanlop <[email protected]> * Automatic port of *PipeServerStreamAcl docs (#4880) * Automatic port of *PipeServerStreamAcl docs * Apply suggestions from code review Co-authored-by: Prashanth Govindarajan <[email protected]> Co-authored-by: David Cantú <[email protected]> * Apply suggestions from code review Co-authored-by: David Cantú <[email protected]> * Apply suggestions from code review * Update xml/System.IO.Pipes/AnonymousPipeServerStreamAcl.xml * Update xml/System.IO.Pipes/AnonymousPipeServerStreamAcl.xml Co-authored-by: carlossanlop <[email protected]> Co-authored-by: Prashanth Govindarajan <[email protected]> Co-authored-by: David Cantú <[email protected]> * Automatic port of *OSPlatformAttribute docs (#4883) * Automatic port of *OSPlatformAttribute docs * Missing TargetPlatformAttribute constructor parameter description. * Apply suggestions from code review Co-authored-by: Buyaa <[email protected]> * Update xml/System.Runtime.Versioning/SupportedOSPlatformAttribute.xml Co-authored-by: carlossanlop <[email protected]> Co-authored-by: Buyaa <[email protected]> * Document System.Enum (#4894) Co-authored-by: carlossanlop <[email protected]> * Document Half.op_Explicit APIs (#4893) * Document Half.op_Explicit APIs * Equals Co-authored-by: carlossanlop <[email protected]> * Automatic port of Rune.CompareTo EII (#4891) Co-authored-by: carlossanlop <[email protected]> * Add missing docs for AsnContentException. (#4895) * Add missing documentation for S.S.Cryptography (#4892) * Add missing documentation for S.S.Cryptography * Apply feedback * Automatic port of System.Threading.ExecutionContext.Restore doc (#4887) * Automatic port of System.Threading.ExecutionContext.Restore doc * Update xml/System.Threading/ExecutionContext.xml Co-authored-by: Prashanth Govindarajan <[email protected]> * Apply suggestions from code review Co-authored-by: carlossanlop <[email protected]> Co-authored-by: Prashanth Govindarajan <[email protected]> * Automatic port of explicit interface implementation of System.Net.Http.HttpRequestOptions (#4881) * Automatic port of explicit interface implementations for System.Net.Http.HttpRequestOptions * Apply suggestions from code review Co-authored-by: Jan Jahoda <[email protected]> Co-authored-by: carlossanlop <[email protected]> Co-authored-by: Jan Jahoda <[email protected]> * Document Type.IsAssignableTo (#4898) Co-authored-by: carlossanlop <[email protected]> * Document System.PlatformID.Other (#4897) Co-authored-by: carlossanlop <[email protected]> * HTTP Version Selection (#4870) * Sync docs with source comments * Apply suggestions from code review Co-authored-by: Genevieve Warren <[email protected]> * Apply suggestions from code review Co-authored-by: Carlos Sanchez <[email protected]> Co-authored-by: Genevieve Warren <[email protected]> * Add values Co-authored-by: Jan Jahoda <[email protected]> Co-authored-by: Genevieve Warren <[email protected]> Co-authored-by: Carlos Sanchez <[email protected]> * HttpClient sync operations (#4776) * Draft for @ManickaP * Apply suggestions from code review Co-authored-by: Marie Píchová <[email protected]> * Format verification * Format verification * Fix links * Fix links * Fix xml tag * Fix links * Fix links * Fix links * Apply suggestions from code review Co-authored-by: Carlos Sanchez <[email protected]> * Fix links * Add CreateContentReadStream * Fix links * Add System.Net.Http.DelegatingHandler.Send * Fix links * Apply suggestions from code review Co-authored-by: Carlos Sanchez <[email protected]> * Remove "Synchronous" information from summary * Apply suggestions from code review Co-authored-by: Genevieve Warren <[email protected]> Co-authored-by: Carlos Sanchez <[email protected]> * Fix the exception description Co-authored-by: Jan Jahoda <[email protected]> Co-authored-by: Marie Píchová <[email protected]> Co-authored-by: Carlos Sanchez <[email protected]> Co-authored-by: Genevieve Warren <[email protected]> * adding docs for missing 5.0 apis for system.Runtime.CompilerServices.Unsafe (#4902) * adding docs for missing 5.0 apis * Apply suggestions from code review Co-authored-by: Carlos Sanchez <[email protected]> * resolve conflict * Add Sysytem.Net.* missing API (#4904) * System.Net.Http.SocketsHttpHandler.EnableMultipleHttp2Connections * Add Sysytem.Net.\* missing API * Apply PR comments * Apply suggestions from code review * Apply suggestions from code review * Update xml/System.Net.Http/SocketsHttpHandler.xml Co-authored-by: Jan Jahoda <[email protected]> Co-authored-by: Carlos Sanchez <[email protected]> * Http sync follow up (#4905) * Add the http sync follow up * Fix closing tag Co-authored-by: Jan Jahoda <[email protected]> Co-authored-by: carlossanlop <[email protected]> Co-authored-by: Tarek Mahmoud Sayed <[email protected]> Co-authored-by: Prashanth Govindarajan <[email protected]> Co-authored-by: Jan Jahoda <[email protected]> Co-authored-by: Jan Jahoda <[email protected]> Co-authored-by: Genevieve Warren <[email protected]> Co-authored-by: David Cantú <[email protected]> Co-authored-by: Buyaa <[email protected]> Co-authored-by: Jeremy Barton <[email protected]> Co-authored-by: Jan Jahoda <[email protected]> Co-authored-by: Marie Píchová <[email protected]> Co-authored-by: Anirudh Agnihotry <[email protected]>
* Automatic port of System.Formats.Cbor documentation * Apply suggestions from code review * exception cleaning * list and indentation * Apply suggestions from code review * Apply suggestions from code review Co-authored-by: David Cantú <[email protected]> * Apply suggestions from code review * Apply suggestions from code review Co-authored-by: David Cantú <[email protected]> * Apply suggestions from code review Co-authored-by: Eirik Tsarpalis <[email protected]> Co-authored-by: carlossanlop <[email protected]> Co-authored-by: David Cantú <[email protected]> Co-authored-by: Eirik Tsarpalis <[email protected]>
Any idea why this would have merge conflicts? That seems odd for the build pipeline. |
Thanks, I didn't see that but it's resolved now. I had to add that method back manually due to https://ceapex.visualstudio.com/Engineering/_workitems/edit/298401. |
Docs Build status updates of commit c69bb5f: ✅ Validation status: passed
This comment lists only the first 50 files in the pull request. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I skimmed a set of the changes, and this LGTM.
You can when ready.
<param name="minor">The minor release number.</param> | ||
<param name="build">The build release number.</param> | ||
<param name="revision">The revision release number.</param> | ||
<summary>Check for the Android version (returned by <code>uname</code>) with a >= version comparison. This is used to guard APIs that were added in the given Android release.</summary> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure what uname refers to here and in IsFreeBSDVersionAtLeast.
Docs Build status updates of commit 2b9543f: ✅ Validation status: passed
This comment lists only the first 50 files in the pull request. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
No description provided.