Skip to content

Conversation

gewarren
Copy link
Contributor

No description provided.

VSC-Service-Account and others added 3 commits September 24, 2020 01:12
 Build.Reason:Manual by Genevieve Warren
 Build.Url:https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=164203&view=results
 source_repo.branch:net5-rc2
 source_repo.url:https://apidrop.visualstudio.com/_git/binaries
* Automatic port of System.OperatingSystem docs for RC2 (#4852)

Co-authored-by: carlossanlop <[email protected]>

* Add Missing System.Diagnostics docs (#4856)

* Add Missing System.Diagnostics docs

* Apply suggestions from code review

Co-authored-by: Carlos Sanchez <[email protected]>

Co-authored-by: Carlos Sanchez <[email protected]>

* Automatically port System.Diagnostics docs for RC2 (#4853)

* Automatically port System.Diagnostics docs for RC2

* Update xml/System.Diagnostics/ActivitySamplingResult.xml

Co-authored-by: Carlos Sanchez <[email protected]>

* Update xml/System.Diagnostics/Process.xml

Co-authored-by: carlossanlop <[email protected]>
Co-authored-by: Tarek Mahmoud Sayed <[email protected]>

* Automatic port of RegexParse* documentation (#4850)

* Automatic port of RegexParse* documentation

* Update xml/System.Text.RegularExpressions/RegexParseError.xml

* Apply suggestions from code review

* Update RegexParseException

* Update xml/System.Text.RegularExpressions/RegexParseException.xml

* Update xml/System.Text.RegularExpressions/RegexParseException.xml

Co-authored-by: carlossanlop <[email protected]>
Co-authored-by: Prashanth Govindarajan <[email protected]>

* Add ssl API added between preview 7 and 8 (#4860)

* Automatic port of Reflection RC2 documentation (#4851)

* Revert "Add ssl API added between preview 7 and 8 (#4860)" (#4868)

This reverts commit 10d2b88.

* Add ssl API added between preview 7 and 8 #2 (#4869)

* Add ssl API added between preview 7 and 8

* Apply suggestions from code review

Co-authored-by: Genevieve Warren <[email protected]>

* Update xml/System.Net.Security/SslStream.xml

* Apply @wfurt comments

* Add missing remark headers

* Apply suggestions from code review

Co-authored-by: Genevieve Warren <[email protected]>

Co-authored-by: Jan Jahoda <[email protected]>
Co-authored-by: Genevieve Warren <[email protected]>

* Documentation for System.Net.Http.SocketsHttpHandler.ConnectCallback (#4861)

* Documentation for System.Net.Http.SocketsHttpHandler.ConnectCallback

* Apply PR comments

* Apply suggestions from code review

Co-authored-by: Genevieve Warren <[email protected]>

Co-authored-by: Jan Jahoda <[email protected]>
Co-authored-by: Genevieve Warren <[email protected]>

* Add a remark to AddEvent method (#4871)

* Add a remark to AddEvent method

* Apply suggestions from code review

Co-authored-by: Genevieve Warren <[email protected]>

Co-authored-by: Genevieve Warren <[email protected]>

* Automatic port of CryptoStream docs (#4888)

Co-authored-by: carlossanlop <[email protected]>

* Automatic port of System.Buffers docs (#4882)

Co-authored-by: carlossanlop <[email protected]>

* resolve isprefix conflict

* Automatic port of System.Data.Common docs (#4885)

Co-authored-by: carlossanlop <[email protected]>

* Automatic port of *PipeServerStreamAcl docs (#4880)

* Automatic port of *PipeServerStreamAcl docs

* Apply suggestions from code review

Co-authored-by: Prashanth Govindarajan <[email protected]>
Co-authored-by: David Cantú <[email protected]>

* Apply suggestions from code review

Co-authored-by: David Cantú <[email protected]>

* Apply suggestions from code review

* Update xml/System.IO.Pipes/AnonymousPipeServerStreamAcl.xml

* Update xml/System.IO.Pipes/AnonymousPipeServerStreamAcl.xml

Co-authored-by: carlossanlop <[email protected]>
Co-authored-by: Prashanth Govindarajan <[email protected]>
Co-authored-by: David Cantú <[email protected]>

* Automatic port of *OSPlatformAttribute docs (#4883)

* Automatic port of *OSPlatformAttribute docs

* Missing TargetPlatformAttribute constructor parameter description.

* Apply suggestions from code review

Co-authored-by: Buyaa <[email protected]>

* Update xml/System.Runtime.Versioning/SupportedOSPlatformAttribute.xml

Co-authored-by: carlossanlop <[email protected]>
Co-authored-by: Buyaa <[email protected]>

* Document System.Enum (#4894)

Co-authored-by: carlossanlop <[email protected]>

* Document Half.op_Explicit APIs (#4893)

* Document Half.op_Explicit APIs

* Equals

Co-authored-by: carlossanlop <[email protected]>

* Automatic port of Rune.CompareTo EII (#4891)

Co-authored-by: carlossanlop <[email protected]>

* Add missing docs for AsnContentException. (#4895)

* Add missing documentation for S.S.Cryptography (#4892)

* Add missing documentation for S.S.Cryptography

* Apply feedback

* Automatic port of System.Threading.ExecutionContext.Restore doc (#4887)

* Automatic port of System.Threading.ExecutionContext.Restore doc

* Update xml/System.Threading/ExecutionContext.xml

Co-authored-by: Prashanth Govindarajan <[email protected]>

* Apply suggestions from code review

Co-authored-by: carlossanlop <[email protected]>
Co-authored-by: Prashanth Govindarajan <[email protected]>

* Automatic port of  explicit interface implementation of System.Net.Http.HttpRequestOptions (#4881)

* Automatic port of explicit interface implementations for System.Net.Http.HttpRequestOptions

* Apply suggestions from code review

Co-authored-by: Jan Jahoda <[email protected]>

Co-authored-by: carlossanlop <[email protected]>
Co-authored-by: Jan Jahoda <[email protected]>

* Document Type.IsAssignableTo (#4898)

Co-authored-by: carlossanlop <[email protected]>

* Document System.PlatformID.Other (#4897)

Co-authored-by: carlossanlop <[email protected]>

* HTTP Version Selection (#4870)

* Sync docs with source comments

* Apply suggestions from code review

Co-authored-by: Genevieve Warren <[email protected]>

* Apply suggestions from code review

Co-authored-by: Carlos Sanchez <[email protected]>
Co-authored-by: Genevieve Warren <[email protected]>

* Add values

Co-authored-by: Jan Jahoda <[email protected]>
Co-authored-by: Genevieve Warren <[email protected]>
Co-authored-by: Carlos Sanchez <[email protected]>

* HttpClient sync operations (#4776)

* Draft for @ManickaP

* Apply suggestions from code review

Co-authored-by: Marie Píchová <[email protected]>

* Format verification

* Format verification

* Fix links

* Fix links

* Fix xml tag

* Fix links

* Fix links

* Fix links

* Apply suggestions from code review

Co-authored-by: Carlos Sanchez <[email protected]>

* Fix links

* Add CreateContentReadStream

* Fix links

* Add System.Net.Http.DelegatingHandler.Send

* Fix links

* Apply suggestions from code review

Co-authored-by: Carlos Sanchez <[email protected]>

* Remove "Synchronous" information from summary

* Apply suggestions from code review

Co-authored-by: Genevieve Warren <[email protected]>
Co-authored-by: Carlos Sanchez <[email protected]>

* Fix the  exception description

Co-authored-by: Jan Jahoda <[email protected]>
Co-authored-by: Marie Píchová <[email protected]>
Co-authored-by: Carlos Sanchez <[email protected]>
Co-authored-by: Genevieve Warren <[email protected]>

* adding docs for missing 5.0 apis for system.Runtime.CompilerServices.Unsafe  (#4902)

* adding docs for missing 5.0 apis

* Apply suggestions from code review

Co-authored-by: Carlos Sanchez <[email protected]>

* resolve conflict

* Add Sysytem.Net.* missing API (#4904)

* System.Net.Http.SocketsHttpHandler.EnableMultipleHttp2Connections

* Add Sysytem.Net.\* missing API

* Apply PR comments

* Apply suggestions from code review

* Apply suggestions from code review

* Update xml/System.Net.Http/SocketsHttpHandler.xml

Co-authored-by: Jan Jahoda <[email protected]>
Co-authored-by: Carlos Sanchez <[email protected]>

* Http sync follow up (#4905)

* Add the http sync follow up

* Fix closing tag

Co-authored-by: Jan Jahoda <[email protected]>

Co-authored-by: carlossanlop <[email protected]>
Co-authored-by: Tarek Mahmoud Sayed <[email protected]>
Co-authored-by: Prashanth Govindarajan <[email protected]>
Co-authored-by: Jan Jahoda <[email protected]>
Co-authored-by: Jan Jahoda <[email protected]>
Co-authored-by: Genevieve Warren <[email protected]>
Co-authored-by: David Cantú <[email protected]>
Co-authored-by: Buyaa <[email protected]>
Co-authored-by: Jeremy Barton <[email protected]>
Co-authored-by: Jan Jahoda <[email protected]>
Co-authored-by: Marie Píchová <[email protected]>
Co-authored-by: Anirudh Agnihotry <[email protected]>
* Automatic port of System.Formats.Cbor documentation

* Apply suggestions from code review

* exception cleaning

* list and indentation

* Apply suggestions from code review

* Apply suggestions from code review

Co-authored-by: David Cantú <[email protected]>

* Apply suggestions from code review

* Apply suggestions from code review

Co-authored-by: David Cantú <[email protected]>

* Apply suggestions from code review

Co-authored-by: Eirik Tsarpalis <[email protected]>

Co-authored-by: carlossanlop <[email protected]>
Co-authored-by: David Cantú <[email protected]>
Co-authored-by: Eirik Tsarpalis <[email protected]>
@opbld30
Copy link

opbld30 commented Oct 13, 2020

Docs Build status updates of commit e5bd866:

✅ Validation status: passed

File Status Preview URL Details
xml/FrameworksIndex/dotnet-plat-ext-5.0.xml ✅Succeeded
xml/FrameworksIndex/net-5.0.xml ✅Succeeded
xml/Microsoft.Extensions.DependencyInjection/OptionsBuilderConfigurationExtensions.xml ✅Succeeded View
xml/Microsoft.Extensions.Logging/ConsoleLoggerExtensions.xml ✅Succeeded View
xml/Microsoft.Extensions.Logging/LoggingBuilderExtensions.xml ✅Succeeded View
xml/System.Buffers/ReadOnlySequence`1.xml ✅Succeeded View
xml/System.Buffers/SequenceReader`1.xml ✅Succeeded View
xml/System.Collections.Generic/CollectionExtensions.xml ✅Succeeded View
xml/System.Collections.Generic/LinkedListNode`1.xml ✅Succeeded View
xml/System.Collections.Immutable/ImmutableArray`1.xml ✅Succeeded View
xml/System.ComponentModel.DataAnnotations/CompareAttribute.xml ✅Succeeded View
xml/System.ComponentModel.DataAnnotations/FilterUIHintAttribute.xml ✅Succeeded View
xml/System.ComponentModel.DataAnnotations/ValidationAttribute.xml ✅Succeeded View
xml/System.Data.Common/DataColumnMapping.xml ✅Succeeded View
xml/System.Data.Common/DbTransaction.xml ✅Succeeded View
xml/System.Data.OleDb/OleDbCommand.xml ✅Succeeded View
xml/System.Data/DataSet.xml ✅Succeeded View
xml/System.Data/DataView.xml ✅Succeeded View
xml/System.Diagnostics/Activity.xml ✅Succeeded View
xml/System.Diagnostics/ActivityContext.xml ✅Succeeded View
xml/System.Diagnostics/ActivityCreationOptions`1.xml ✅Succeeded View
xml/System.Diagnostics/ActivityListener.xml ✅Succeeded View
xml/System.Diagnostics/ActivitySamplingResult.xml ✅Succeeded View
xml/System.Diagnostics/ActivityTagsCollection.xml ✅Succeeded View
xml/System.Diagnostics/Process.xml ✅Succeeded View
xml/System.Diagnostics/SampleActivity`1.xml ✅Succeeded View
xml/System.Formats.Asn1/AsnContentException.xml ✅Succeeded View
xml/System.Formats.Cbor/CborConformanceMode.xml ✅Succeeded View
xml/System.Formats.Cbor/CborContentException.xml ✅Succeeded View
xml/System.Formats.Cbor/CborReader.xml ✅Succeeded View
xml/System.Formats.Cbor/CborReaderState.xml ✅Succeeded View
xml/System.Formats.Cbor/CborSimpleValue.xml ✅Succeeded View
xml/System.Formats.Cbor/CborTag.xml ✅Succeeded View
xml/System.Formats.Cbor/CborWriter.xml ✅Succeeded View
xml/System.Globalization/CompareInfo.xml ✅Succeeded View
xml/System.IO.Packaging/PackUriHelper.xml ✅Succeeded View
xml/System.IO.Pipes/AnonymousPipeServerStreamAcl.xml ✅Succeeded View
xml/System.IO.Pipes/NamedPipeServerStream.xml ✅Succeeded View
xml/System.IO.Pipes/NamedPipeServerStreamAcl.xml ✅Succeeded View
xml/System.Net.Http/ByteArrayContent.xml ✅Succeeded View
xml/System.Net.Http/DelegatingHandler.xml ✅Succeeded View
xml/System.Net.Http/HeaderEncodingSelector`1.xml ✅Succeeded View
xml/System.Net.Http/HttpClient.xml ✅Succeeded View
xml/System.Net.Http/HttpClientHandler.xml ✅Succeeded View
xml/System.Net.Http/HttpContent.xml ✅Succeeded View
xml/System.Net.Http/HttpKeepAlivePingPolicy.xml ✅Succeeded View
xml/System.Net.Http/HttpMessageHandler.xml ✅Succeeded View
xml/System.Net.Http/HttpMessageInvoker.xml ✅Succeeded View
xml/System.Net.Http/HttpRequestMessage.xml ✅Succeeded View
xml/System.Net.Http/HttpRequestOptions.xml ✅Succeeded View

This comment lists only the first 50 files in the pull request.
For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@BillWagner
Copy link
Member

Any idea why this would have merge conflicts? That seems odd for the build pipeline.

@gewarren
Copy link
Contributor Author

Any idea why this would have merge conflicts? That seems odd for the build pipeline.

Thanks, I didn't see that but it's resolved now. I had to add that method back manually due to https://ceapex.visualstudio.com/Engineering/_workitems/edit/298401.

@opbld33
Copy link

opbld33 commented Oct 14, 2020

Docs Build status updates of commit c69bb5f:

✅ Validation status: passed

File Status Preview URL Details
xml/FrameworksIndex/dotnet-plat-ext-5.0.xml ✅Succeeded
xml/FrameworksIndex/net-5.0.xml ✅Succeeded
xml/Microsoft.Extensions.DependencyInjection/OptionsBuilderConfigurationExtensions.xml ✅Succeeded View
xml/Microsoft.Extensions.Logging/ConsoleLoggerExtensions.xml ✅Succeeded View
xml/System.Buffers/ReadOnlySequence`1.xml ✅Succeeded View
xml/System.Buffers/SequenceReader`1.xml ✅Succeeded View
xml/System.Collections.Generic/CollectionExtensions.xml ✅Succeeded View
xml/System.Collections.Generic/LinkedListNode`1.xml ✅Succeeded View
xml/System.Collections.Immutable/ImmutableArray`1.xml ✅Succeeded View
xml/System.ComponentModel.DataAnnotations/CompareAttribute.xml ✅Succeeded View
xml/System.ComponentModel.DataAnnotations/FilterUIHintAttribute.xml ✅Succeeded View
xml/System.ComponentModel.DataAnnotations/ValidationAttribute.xml ✅Succeeded View
xml/System.Data.Common/DataColumnMapping.xml ✅Succeeded View
xml/System.Data.Common/DbTransaction.xml ✅Succeeded View
xml/System.Data.OleDb/OleDbCommand.xml ✅Succeeded View
xml/System.Data/DataSet.xml ✅Succeeded View
xml/System.Data/DataView.xml ✅Succeeded View
xml/System.Diagnostics/Activity.xml ✅Succeeded View
xml/System.Diagnostics/ActivityContext.xml ✅Succeeded View
xml/System.Diagnostics/ActivityCreationOptions`1.xml ✅Succeeded View
xml/System.Diagnostics/ActivityListener.xml ✅Succeeded View
xml/System.Diagnostics/ActivitySamplingResult.xml ✅Succeeded View
xml/System.Diagnostics/ActivityTagsCollection.xml ✅Succeeded View
xml/System.Diagnostics/Process.xml ✅Succeeded View
xml/System.Diagnostics/SampleActivity`1.xml ✅Succeeded View
xml/System.Formats.Asn1/AsnContentException.xml ✅Succeeded View
xml/System.Formats.Cbor/CborConformanceMode.xml ✅Succeeded View
xml/System.Formats.Cbor/CborContentException.xml ✅Succeeded View
xml/System.Formats.Cbor/CborReader.xml ✅Succeeded View
xml/System.Formats.Cbor/CborReaderState.xml ✅Succeeded View
xml/System.Formats.Cbor/CborSimpleValue.xml ✅Succeeded View
xml/System.Formats.Cbor/CborTag.xml ✅Succeeded View
xml/System.Formats.Cbor/CborWriter.xml ✅Succeeded View
xml/System.Globalization/CompareInfo.xml ✅Succeeded View
xml/System.IO.Packaging/PackUriHelper.xml ✅Succeeded View
xml/System.IO.Pipes/AnonymousPipeServerStreamAcl.xml ✅Succeeded View
xml/System.IO.Pipes/NamedPipeServerStream.xml ✅Succeeded View
xml/System.IO.Pipes/NamedPipeServerStreamAcl.xml ✅Succeeded View
xml/System.Net.Http/ByteArrayContent.xml ✅Succeeded View
xml/System.Net.Http/DelegatingHandler.xml ✅Succeeded View
xml/System.Net.Http/HeaderEncodingSelector`1.xml ✅Succeeded View
xml/System.Net.Http/HttpClient.xml ✅Succeeded View
xml/System.Net.Http/HttpClientHandler.xml ✅Succeeded View
xml/System.Net.Http/HttpContent.xml ✅Succeeded View
xml/System.Net.Http/HttpKeepAlivePingPolicy.xml ✅Succeeded View
xml/System.Net.Http/HttpMessageHandler.xml ✅Succeeded View
xml/System.Net.Http/HttpMessageInvoker.xml ✅Succeeded View
xml/System.Net.Http/HttpRequestMessage.xml ✅Succeeded View
xml/System.Net.Http/HttpRequestOptions.xml ✅Succeeded View
xml/System.Net.Http/HttpVersionPolicy.xml ✅Succeeded View

This comment lists only the first 50 files in the pull request.
For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I skimmed a set of the changes, and this LGTM.

You can :shipit: when ready.

<param name="minor">The minor release number.</param>
<param name="build">The build release number.</param>
<param name="revision">The revision release number.</param>
<summary>Check for the Android version (returned by <code>uname</code>) with a &gt;= version comparison. This is used to guard APIs that were added in the given Android release.</summary>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what uname refers to here and in IsFreeBSDVersionAtLeast.

@opbld33
Copy link

opbld33 commented Oct 14, 2020

Docs Build status updates of commit 2b9543f:

✅ Validation status: passed

File Status Preview URL Details
xml/FrameworksIndex/dotnet-plat-ext-5.0.xml ✅Succeeded
xml/FrameworksIndex/net-5.0.xml ✅Succeeded
xml/Microsoft.Extensions.DependencyInjection/OptionsBuilderConfigurationExtensions.xml ✅Succeeded View
xml/Microsoft.Extensions.Logging/ConsoleLoggerExtensions.xml ✅Succeeded View
xml/System.Buffers/ReadOnlySequence`1.xml ✅Succeeded View
xml/System.Buffers/SequenceReader`1.xml ✅Succeeded View
xml/System.Collections.Generic/CollectionExtensions.xml ✅Succeeded View
xml/System.Collections.Generic/LinkedListNode`1.xml ✅Succeeded View
xml/System.Collections.Immutable/ImmutableArray`1.xml ✅Succeeded View
xml/System.ComponentModel.DataAnnotations/CompareAttribute.xml ✅Succeeded View
xml/System.ComponentModel.DataAnnotations/FilterUIHintAttribute.xml ✅Succeeded View
xml/System.ComponentModel.DataAnnotations/ValidationAttribute.xml ✅Succeeded View
xml/System.Data.Common/DataColumnMapping.xml ✅Succeeded View
xml/System.Data.Common/DbTransaction.xml ✅Succeeded View
xml/System.Data.OleDb/OleDbCommand.xml ✅Succeeded View
xml/System.Data/DataSet.xml ✅Succeeded View
xml/System.Data/DataView.xml ✅Succeeded View
xml/System.Diagnostics/Activity.xml ✅Succeeded View
xml/System.Diagnostics/ActivityContext.xml ✅Succeeded View
xml/System.Diagnostics/ActivityCreationOptions`1.xml ✅Succeeded View
xml/System.Diagnostics/ActivityListener.xml ✅Succeeded View
xml/System.Diagnostics/ActivitySamplingResult.xml ✅Succeeded View
xml/System.Diagnostics/ActivityTagsCollection.xml ✅Succeeded View
xml/System.Diagnostics/Process.xml ✅Succeeded View
xml/System.Diagnostics/SampleActivity`1.xml ✅Succeeded View
xml/System.Formats.Asn1/AsnContentException.xml ✅Succeeded View
xml/System.Formats.Cbor/CborConformanceMode.xml ✅Succeeded View
xml/System.Formats.Cbor/CborContentException.xml ✅Succeeded View
xml/System.Formats.Cbor/CborReader.xml ✅Succeeded View
xml/System.Formats.Cbor/CborReaderState.xml ✅Succeeded View
xml/System.Formats.Cbor/CborSimpleValue.xml ✅Succeeded View
xml/System.Formats.Cbor/CborTag.xml ✅Succeeded View
xml/System.Formats.Cbor/CborWriter.xml ✅Succeeded View
xml/System.Globalization/CompareInfo.xml ✅Succeeded View
xml/System.IO.Packaging/PackUriHelper.xml ✅Succeeded View
xml/System.IO.Pipes/AnonymousPipeServerStreamAcl.xml ✅Succeeded View
xml/System.IO.Pipes/NamedPipeServerStream.xml ✅Succeeded View
xml/System.IO.Pipes/NamedPipeServerStreamAcl.xml ✅Succeeded View
xml/System.Net.Http/ByteArrayContent.xml ✅Succeeded View
xml/System.Net.Http/DelegatingHandler.xml ✅Succeeded View
xml/System.Net.Http/HeaderEncodingSelector`1.xml ✅Succeeded View
xml/System.Net.Http/HttpClient.xml ✅Succeeded View
xml/System.Net.Http/HttpClientHandler.xml ✅Succeeded View
xml/System.Net.Http/HttpContent.xml ✅Succeeded View
xml/System.Net.Http/HttpKeepAlivePingPolicy.xml ✅Succeeded View
xml/System.Net.Http/HttpMessageHandler.xml ✅Succeeded View
xml/System.Net.Http/HttpMessageInvoker.xml ✅Succeeded View
xml/System.Net.Http/HttpRequestMessage.xml ✅Succeeded View
xml/System.Net.Http/HttpRequestOptions.xml ✅Succeeded View
xml/System.Net.Http/HttpVersionPolicy.xml ✅Succeeded View

This comment lists only the first 50 files in the pull request.
For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@gewarren gewarren merged commit c9445d2 into master Oct 14, 2020
@eiriktsarpalis eiriktsarpalis added the area-Meta Concerns something that extends across runtime area boundaries, for example, IDisposable. label Mar 1, 2021
@gewarren gewarren deleted the release-net5-rc2 branch April 6, 2021 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Meta Concerns something that extends across runtime area boundaries, for example, IDisposable.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants