Skip to content

Conversation

@vcsjones
Copy link
Member

Summary

DataTable.Rows contained a remark about returning null if there are no rows. Best of my knowledge, this property will never return null on .NET Core / 5 or in .NET Framework.

@opbld30
Copy link

opbld30 commented Oct 14, 2020

Docs Build status updates of commit a414b45:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Data/DataTable.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@David-Engel
Copy link
Contributor

It appears that way to me, too. @roji would be a good authoritative reviewer for this, though.

@David-Engel David-Engel requested a review from roji October 21, 2020 23:30
Copy link
Member

@roji roji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, DataTable.Rows doesn't seem like it can ever return null, and has been annotated accordingly for C# NRTs in .NET 5.0.

@eiriktsarpalis eiriktsarpalis added the area-System.Data Data APIs (ADO.NET, XML, etc). label Feb 25, 2021
@gewarren gewarren merged commit 9c063dd into dotnet:master Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-System.Data Data APIs (ADO.NET, XML, etc).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants