Fix dotnet/docs#8427 remove out of place remarks #645
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Summary Removes duplicate and out of place information about URL Encoding from the `JavaScriptStringEncode` methods, where it may be misleading. The documentation for `UrlEncode` is already more complete, and this isn't relevant to JavaScript specific string encoding. Fixes dotnet/docs#8427
Chris-Johnston
changed the title
rpetrusha
approved these changes
Oct 22, 2018
rpetrusha
left a comment
rpetrusha
left a comment
There was a problem hiding this comment.
Thanks, @Chris-Johnston, for contributing to the dotnet/dotnet-api-docs repo and for removing the extraneous comment. I'll approve your PR now and merge it shortly. The change should be live on docs.microsoft.com in the next day or two.
rpetrusha
changed the title
rpetrusha
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Removes duplicate and out of place information about URL Encoding from the
JavaScriptStringEncodemethods, where it may be misleading. The documentation forUrlEncodeis already more complete, and this isn't relevant to JavaScript specific string encoding.Fixes dotnet/docs#8427