Skip to content

Conversation

@vcsjones
Copy link
Member

@vcsjones vcsjones commented May 3, 2021

Summary

This property, for historical purposes, is instance-based but is backed by a static field, so changes are observed between instances.

Fixes dotnet/runtime#46256

This property, for historical purposes, is instance-based but is
backed by a static field, so changes are observed between instances.
@ghost ghost added the area-System.Security Issues related to security practices for .NET developers. label May 3, 2021
@ghost
Copy link

ghost commented May 3, 2021

Tagging subscribers to this area: @bartonjs, @vcsjones, @krwq, @GrabYourPitchforks
See info in area-owners.md if you want to be subscribed.

Issue Details

Summary

This property, for historical purposes, is instance-based but is backed by a static field, so changes are observed between instances.

Fixes dotnet/runtime#46256

Author: vcsjones
Assignees: -
Labels:

area-System.Security

Milestone: -

@bartonjs
Copy link
Member

bartonjs commented May 3, 2021

Technical content LGTM. @gewarren do you have any style or language changes you'd like to see?

@opbld30
Copy link

opbld30 commented May 3, 2021

Docs Build status updates of commit 9400daa:

⚠️ Validation status: warnings

File Status Preview URL Details
xml/System.Security.Cryptography.Xml/SignedXml.xml ⚠️Warning View Details

xml/System.Security.Cryptography.Xml/SignedXml.xml

  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Security.Cryptography.Xml.SignedXml*'.

For more details, please refer to the build report.

If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@opbld33
Copy link

opbld33 commented May 3, 2021

Docs Build status updates of commit 4573f55:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Security.Cryptography.Xml/SignedXml.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

Copy link
Contributor

@gewarren gewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'll merge it now; thanks!

@gewarren gewarren merged commit 2999fc4 into dotnet:main May 3, 2021
@vcsjones vcsjones deleted the signed-xml-c14n-docs branch May 4, 2021 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-System.Security Issues related to security practices for .NET developers.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SignedXml SafeCanonicalizationMethods behaves like static property

5 participants