Noted deprecated CultureTypes members #696
Conversation
rpetrusha
added
the
🚧 Hold for related PR
rpetrusha
changed the title
BillWagner
left a comment
BillWagner
left a comment
There was a problem hiding this comment.
These changes LGTM @rpetrusha
You can 
when ready.
I like the way you split the samples PR in 2: one preceding and one following this PR. We should adopt that as a practice for our team.
| <MemberValue>7</MemberValue> | ||
| <Docs> | ||
| <summary>All cultures that ship with the .NET Framework, including neutral and specific cultures, cultures installed in the Windows operating system, and custom cultures created by the user. | ||
| <summary>All cultures that ship with .NET, including neutral and specific cultures, cultures installed with the operating system, and custom cultures created by the user. |
There was a problem hiding this comment.
Would be better to say this is for .NET 4+
There was a problem hiding this comment.
.NET 4.0+ don't ship any culture data. we just depend on the cultures exist in the OS (Windows) or whatever cultures included in the ICU ( for .Net Core on Linux/OSX). 2.x and 3.x are the versions that carry culture data
| ## Remarks | ||
| Note that not all cultures supported by the .NET Framework are installed in the Windows operating system. |
There was a problem hiding this comment.
This statement can be true from 2.0 versions but not for 4.0+
| ## Remarks | ||
| If it is used as an argument to the <xref:System.Globalization.CultureInfo.GetCultures%2A?displayProperty=nameWithType> method, the method returns an empty array. |
There was a problem hiding this comment.
This is 4.0+ behavior and not 2.x/3.x.
|
@rpetrusha want to ensure you saw my comments. |
|
I have no idea why, @tarekgh, but I didn't see them. Since this was merged, I'll open a new PR to address them. |
mairaw
removed
the
🚧 Hold for related PR
4 participants
Noted deprecated CultureTypes members
Fixes dotnet/docs#7635
This PR depends on dotnet/samples#438.
Once this PR is merged, dotnet/samples#437 can be merged.
//cc @tarekgh