Skip to content

Conversation

@jkotas
Copy link
Member

@jkotas jkotas commented Dec 8, 2021

Describe your changes here.

Add note about timing of type loader exceptions based on the feedback received offline.

Also delete notes about small behavior differences with missing PathDiscoveryPermissions. PathDiscoveryPermissions is part of Code Access Security that was deprecated long time ago. No need to compilate the docs for it.

…ions

PathDiscovery is part of Code Access Security that has been deprecated for a long time. No need to complicate the docs by highlighting minor differences.
@jkotas jkotas requested review from a team as code owners December 8, 2021 21:11
@ghost ghost added the area-System.IO label Dec 8, 2021
@ghost
Copy link

ghost commented Dec 8, 2021

Tagging subscribers to this area: @carlossanlop
See info in area-owners.md if you want to be subscribed.

Issue Details

Describe your changes here.

Add note about timing of type loader exceptions based on the feedback received offline.

Also delete notes about small behavior differences with missing PathDiscoveryPermissions. PathDiscoveryPermissions is part of Code Access Security that was deprecated long time ago. No need to compilate the docs for it.

Author: jkotas
Assignees: -
Labels:

area-System.IO

Milestone: -

@opbld30
Copy link

opbld30 commented Dec 8, 2021

Docs Build status updates of commit 97f4b05:

✅ Validation status: passed

File Status Preview URL Details
xml/System.IO/DirectoryNotFoundException.xml ✅Succeeded View
xml/System.IO/FileLoadException.xml ✅Succeeded View
xml/System.IO/FileNotFoundException.xml ✅Succeeded View
xml/System.IO/PathTooLongException.xml ✅Succeeded View
xml/System/MissingMethodException.xml ✅Succeeded View
xml/System/TypeLoadException.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

Co-authored-by: Genevieve Warren <[email protected]>
@opbld31
Copy link

opbld31 commented Dec 9, 2021

Docs Build status updates of commit b083832:

✅ Validation status: passed

File Status Preview URL Details
xml/System.IO/DirectoryNotFoundException.xml ✅Succeeded View
xml/System.IO/FileLoadException.xml ✅Succeeded View
xml/System.IO/FileNotFoundException.xml ✅Succeeded View
xml/System.IO/PathTooLongException.xml ✅Succeeded View
xml/System/MissingMethodException.xml ✅Succeeded View
xml/System/TypeLoadException.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

Copy link
Contributor

@gewarren gewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@adamsitnik adamsitnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for improving the docs @jkotas !

@gewarren gewarren merged commit 97bfab3 into dotnet:main Dec 9, 2021
@jkotas jkotas deleted the typeloader-exceptions branch September 5, 2023 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants